Skip to content

Add getIconImage method to MediaInfo #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/com/connectsdk/core/MediaInfo.java
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,23 @@ public void setDescription(String description) {
}

/**
* Gets icon image
* @return image, can be null
*/
public ImageInfo getIconImage() {
if (allImages == null || allImages.isEmpty()) {
return null;
}
return allImages.get(0);
}

/**
* This method is deprecated use `getIconImage()` instead
*
* Gets list of ImageInfo objects for images representing a media (ex. icon, poster).
* Where first ([0]) is icon image, and second ([1]) is poster image.
*/
@Deprecated
public List<ImageInfo> getImages() {
return allImages;
}
Expand Down
18 changes: 18 additions & 0 deletions test/src/com/connectsdk/core/MediaInfoTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
import org.robolectric.RobolectricTestRunner;
import org.robolectric.annotation.Config;

import java.util.ArrayList;

@RunWith(RobolectricTestRunner.class)
@Config(manifest = Config.NONE)
public class MediaInfoTest {
Expand All @@ -43,6 +45,7 @@ public void testMediaInfoBuilderWithRequiredParameters() {
Assert.assertNull(mediaInfo.getImages());
Assert.assertNull(mediaInfo.getSubtitleInfo());
Assert.assertNull(mediaInfo.getTitle());
Assert.assertNull(mediaInfo.getIconImage());
}

@Test
Expand All @@ -65,9 +68,24 @@ public void testMediaInfoBuilderWithAllParameters() {
Assert.assertEquals(url, mediaInfo.getUrl());
Assert.assertEquals(mimeType, mediaInfo.getMimeType());
Assert.assertEquals(description, mediaInfo.getDescription());
Assert.assertEquals(iconUrl, mediaInfo.getIconImage().getUrl());
Assert.assertEquals(iconUrl, mediaInfo.getImages().get(0).getUrl());
Assert.assertEquals(1, mediaInfo.getImages().size());
Assert.assertEquals(subtitle, mediaInfo.getSubtitleInfo());
Assert.assertEquals(title, mediaInfo.getTitle());
}

@Test
public void testGetIconImageShouldReturnNullForEmptyImageList() {
MediaInfo mediaInfo = new MediaInfo.Builder("", "").build();
mediaInfo.setImages(new ArrayList<ImageInfo>());
Assert.assertNull(mediaInfo.getIconImage());
}

@Test
public void testAddImagesWithNullArgumentShouldDoNothing() {
MediaInfo mediaInfo = new MediaInfo.Builder("", "").build();
mediaInfo.addImages((ImageInfo[]) null);
Assert.assertNull(mediaInfo.getImages());
}
}