N°5139 - Let data that is null also be null at the other side-fix #52
Conversation
|
I'm only concerned on how to sync a NULL value into a nullable DECIMAL field in iTop. I think that is still not possible, even with these additions? Edit: This is the correct link to the documentation: https://www.itophub.io/wiki/page?id=extensions:itop-data-collector-base#reset_or_untouch |
Could we add a unit test on that to check and to ensure that we keep the intended behavior? |
|
Hi @odain-cbd, what is the status / progress on this PR? |
To classify PRs
…hed from its home directory (#55) * Make sure relative paths can be used when json collector is launched from outside its root directory * Add test for jsonfile parameter defined with relative path * Provider function must be static for PHP 8.2+
Suppress the PHP warning generated by file_get_contents when requested file is not found. The error is handled by the code.
* Log the trimmed output in debug mode when there are no errors * Revert previous default behaviour * Also fix the hardcoded default value
there is a test that covers nullify feature (testAttributeIsNullified). |
Hi Hipska, current PR was on hold on my side. still waiting for reviewers to approve. |
|
That test doesn't actually test if the value on iTop becomes NULL after synchro. It only tests if resulting CSV contains So question remains for very long time; How to synchronise a DECIMAL field to have the resulting value in iTop be NULL? IMHO it has never been able to achieve this. |
| if (is_null($aRow[$sHeader]) && $this->AttributeIsNullified($sHeader)) { | ||
| if (strlen($aRow[$sHeader] ?? '')===0 && $this->AttributeIsNullified($sHeader)) { |
There was a problem hiding this comment.
Empty string is not the same as null.
There was a problem hiding this comment.
indeed yes.
untouched scenario:
for a field, either it is configured as "nullified", and both null or empty string will be sent as <NULL> during datasynchro, which will leave it with its previous value on iTop side (untouched).
reset scenario:
otherwise same field (either null or empty string) will be sent during datasynchro as empty field. which will reset field value to default one.
for some iTop attributes this usecase is supported. for some others it is not. at the end you can decide what to do from collector side (per attribute xml configuration).
There was a problem hiding this comment.
No, The whole thing is to be able to set a field's value as NULL in the SQL database, not reset, not ignore!
So it seems it will still not work and Combodo still doesn't understand the needs.. 😢
So question remains for very long time; How to synchronise a DECIMAL field to have the resulting value in iTop be NULL?
IMHO it has never been able to achieve this.
Current PR intends to enhance "Reset or untouch" option (nullified configuration) to work also for empty string ("") fields values.
During data collection, fields can have a null value. during iTop object synchronization you can decide either
we propose to have same "untouch" behaviour for empty string values collected. as a matter of fact null cannot be collected for some type of collectors (like CSV). which make the "nullify" feature unusable... seems like a bug to me.
https://wiki.combodo.com/doku.php?id=extensions:itop-data-collector-base#reset_or_untouch
#7