Skip to content

Add some tests for iso8601 parsing #3819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

waltdisgrace
Copy link
Contributor

No description provided.

@waltdisgrace waltdisgrace marked this pull request as draft February 5, 2025 16:25
@clumens clumens added the status: in progress PRs that aren't ready yet label Feb 5, 2025
@clumens
Copy link
Contributor

clumens commented Feb 5, 2025

@waltdisgrace CI failed because it doesn't run on draft PRs. If you're ready for this PR to be checked, give it a real commit message and remove the draft mark and CI will run on it. Then we'll be able to see if it finds and problems. Thanks!

@waltdisgrace waltdisgrace marked this pull request as ready for review February 12, 2025 15:51
@waltdisgrace waltdisgrace force-pushed the 188 branch 2 times, most recently from 5e5fab4 to c972aee Compare February 24, 2025 21:11
@fabbione
Copy link
Member

retest this please

(CI had a "moment")

@fabbione
Copy link
Member

retest this please

@waltdisgrace waltdisgrace changed the title t188 Add some tests for iso8601 parsing Mar 3, 2025
@waltdisgrace waltdisgrace requested a review from clumens March 3, 2025 20:52
@clumens
Copy link
Contributor

clumens commented Mar 5, 2025

@waltdisgrace Can you rebase on main and push again? There's a couple patches I added that should increase the verbosity of cts-cli output when running under CI, and they don't appear to be present on your branch. I'm hoping that'll clear up whatever weirdness is going on here.

@waltdisgrace
Copy link
Contributor Author

#3846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in progress PRs that aren't ready yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants