Skip to content

feat: add support for time/time64 #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shivanshuraj1333
Copy link

@shivanshuraj1333 shivanshuraj1333 commented Jul 11, 2025

fixes: #1579

related to ClickHouse/ClickHouse#81217

depends on ClickHouse/ch-go#1074

Summary

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2025

CLA assistant check
All committers have signed the CLA.

@shivanshuraj1333 shivanshuraj1333 changed the title feat: time/time64 timezone test and example build errors feat: add support for time/time64 Jul 11, 2025
@shivanshuraj1333 shivanshuraj1333 marked this pull request as draft July 11, 2025 18:04
@shivanshuraj1333 shivanshuraj1333 marked this pull request as ready for review July 12, 2025 08:42
@@ -22,6 +22,10 @@ require (

require go.opentelemetry.io/otel v1.37.0 // indirect

replace github.com/ClickHouse/ch-go => ../ch-go
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update once ClickHouse/ch-go#1074 is merged

@mshustov mshustov requested a review from SpencerTorres July 13, 2025 09:12
@shivanshuraj1333
Copy link
Author

Hey @SpencerTorres when you get some time, can you please take a look at this one?

(also tagging you as some other PRs which can get some help from your reviews)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Time and Time64 types
2 participants