[Feature] Enable angular-osf development server as alternative to ember-osf-web development server
#11224
+200
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 9, 2025 15:40
- `USE_EXTERNAL_EMBER` -> `USE_EXTERNAL_WEB_APP`
- `PROXY_EMBER_APPS` -> `PROXY_WEB_APPS`
- `EXTERNAL_EMBER_APPS` -> `EXTERNAL_WEB_APPS`
- `EXTERNAL_EMBER_SERVER_TIMEOUT` -> `EXTERNAL_APP_SERVER_TIMEOUT`
- `EMBER_DOMAIN` -> `PRIMARY_WEB_APP_DOMAIN`
- `stream_emberapp` -> `stream_web_app`
- `use_ember_app` -> `use_primary_web_app`
- Identifiers includes `use_ember_app` as part of name are also
converted. same rule.
- directory name `ember_osf_web` -> `external_web_app`
- affected `import` statements are fixed, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR introduces a configuration option,
PRIMARY_WEB_APP, that lets developers select whetherember-osf-weborangular-osfis served as the primary frontend during development.Changes
Make main frontend selectable between
ember-osf-webandangular-osf.PRIMARY_WEB_APPconfiguration option to specify the frontend.ember-osf-webandangular-osffrontends.Apply name conversions for framework-neutral naming.
USE_EXTERNAL_EMBER->USE_EXTERNAL_WEB_APPPROXY_EMBER_APPS->PROXY_WEB_APPSEXTERNAL_EMBER_APPS->EXTERNAL_WEB_APPSEXTERNAL_EMBER_SERVER_TIMEOUT->EXTERNAL_APP_SERVER_TIMEOUTEMBER_DOMAIN->PRIMARY_WEB_APP_DOMAINstream_emberapp->stream_web_appuse_ember_app->use_primary_web_appember_osf_web->external_web_appQA Notes
PRIMARY_WEB_APP = 'ember_osf_web'PRIMARY_WEB_APP = 'angular_osf'Concerns/Considerations/Questions
.docker-compose.envis listed in.gitignore, this PR modifies it (EMBER_DOMAINtoPRIMARY_WEB_APP_DOMAIN).angular-osfis not implemented in this PR. Only hard switch viaPRIMARY_WEB_APP.angular-osflocally,angular.jsonmust be tweaked as follows:osf.architect.build.configurations.development.baseHref:"/angular-osf/assets/"osf.architect.serve.configurations.development.port:4300osf.architect.serve.configurations.development.host:"0.0.0.0"Documentation
website/settings/local-dist.py.Side Effects
None identified. The changes maintain backward compatibility with existing
ember-osf-websetup.Ticket
N/A