Skip to content

[ENG-8085] Upgrade Provider Notifications #11196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: refactor-notifications
Choose a base branch
from

Conversation

Ostap-Zherebetskyi
Copy link
Contributor

Purpose

Upgrade Provider Notifications

Changes

TBD

QA Notes

N/A

Documentation

N/A

Side Effects

N/A

Ticket

https://openscience.atlassian.net/browse/ENG-8085

…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  [ENG-7965] Add v2 email token confirmation endpoints (CenterForOpenScience#11139)
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  fix issue where not having any external identities caused a 500
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  [ENG-7966] Add "collected-in" relationship for Nodes (CenterForOpenScience#11140)
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  fix issue where trying another already confirmed email threw an uncaught exception (CenterForOpenScience#11161)
  [ENG-8148] Add ArtifactOutcome in annotations to linked nodes  (CenterForOpenScience#11158)
…OpenScience/osf.io into add-new-notifications-data-model

* 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io:
  flake8
  fixed tests
  remove quickfiles
  update mails mock
  Update send_mail mocks
  Clean up tests
  Clean up tests
  Clean up imports
  Remove Meetings, Comments and OSF Groups Notifications
  remove osf groups
  remove osf groups
  remove osf groups
  remove osf groups
  remove osf groups

# Conflicts:
#	tests/test_notifications.py
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  Update hybrid values for new workflow check (CenterForOpenScience#11166)
…OpenScience/osf.io into add-new-notifications-data-model

* 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io:
  ignore Django maintenance state outside block
…OpenScience/osf.io into add-new-notifications-data-model

* 'refactor-notifications' of https://github.com/CenterForOpenScience/osf.io:
  fixed bug with contributors
  remove superfluildous `groups` from serializer
  fix new and noteworth nodes bug going to Sentry
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  fixed None issue when iterate (CenterForOpenScience#11192)
  [ENG-8048] Remove caching to avoid incorrect results for ascendants (CenterForOpenScience#11169)
  [ENG-7870] Crossref DOIs not minting with _v1, OSF is displaying DOI versions with _v1 (CenterForOpenScience#11154)
  Update changelog and package.json
  [ENG-8145] [ENG-8147] Manual DOI and GUID for Preprints & Registrations - BE (CenterForOpenScience#11174)
…cience/osf.io into add-new-notifications-data-model

* 'feature/pbs-25-10' of https://github.com/CenterForOpenScience/osf.io:
  Revert "[ENG-8048] Remove caching to avoid incorrect results for ascendants (…"
  Revert "fixed None issue when iterate (CenterForOpenScience#11192)"
@Ostap-Zherebetskyi Ostap-Zherebetskyi force-pushed the feature/provider_notifications branch from 5bce58f to 0485f3d Compare July 7, 2025 10:54
@Ostap-Zherebetskyi Ostap-Zherebetskyi marked this pull request as ready for review July 7, 2025 13:47
 into add-new-notifications-data-model

* 'develop' of https://github.com/CenterForOpenScience/osf.io:
  Bump version no. Add CHANGELOG
  move CROSSREF_UNAVAILABLE_DELAY to settings.py
  handle and 5xx status code from crossref
  handle 500 error from crossref
  Update changelog and package.json
Copy link
Contributor

@Johnetordoff Johnetordoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just base off Johnetordoff:add-new-notifications-data-model and add assertions to existing unittests and/or write new ones if they don't check for the notifications created.

@Ostap-Zherebetskyi Ostap-Zherebetskyi force-pushed the feature/provider_notifications branch from 0485f3d to 6b4ae9c Compare July 9, 2025 09:53
Johnetordoff and others added 3 commits July 9, 2025 10:42
 into refactor-notifications

* 'develop' of https://github.com/CenterForOpenScience/osf.io:
  Update chagnelog and bump version
  [ENG-6835] VRL Project PR - BE (CenterForOpenScience#11204)

# Conflicts:
#	api_tests/registrations/views/test_registration_detail.py
#	conftest.py
#	tests/test_registrations/test_retractions.py
@Ostap-Zherebetskyi Ostap-Zherebetskyi force-pushed the feature/provider_notifications branch from 7f25fd4 to 52263a8 Compare July 10, 2025 11:05
@Johnetordoff Johnetordoff force-pushed the refactor-notifications branch 2 times, most recently from afc3815 to b6bbeed Compare July 11, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants