-
Notifications
You must be signed in to change notification settings - Fork 10
OB-1885: Create install script for VPS Beam Validator Setup #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 Review for OB-1885: VPS Beam Validator Setup
Thank you for automating the AvalancheGo + Beam Subnet-EVM install! This PR greatly simplifies spinning up a validator. A few quick observations:
✅ What’s Working Well
- Interactive prompts guide users through connection type, IP selection, RPC exposure and state-sync choices.
- Modular scripts (
1-install_avalanchego.sh
&2-install_beam_network.sh
) keep concerns separate and easy to maintain. - Verbose logging and post-install instructions (NodeID extraction, systemd status, log tailing) make it clear what to do next.
💡 Suggestions
- Root check & dependencies: Early bail if not run as sudo/root, and verify required binaries (
wget
,jq
,tar
) before proceeding. - Non-interactive mode: Consider adding
--yes
or--quiet
flags for CI/CD or headless installs.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 PR #248 Review: OB-1885 – VPS Beam Validator Setup
Thank you for this comprehensive ops-automation pass! Automating AvalancheGo + Beam Subnet-EVM installation will make validator spin-ups a breeze.
✅ What’s Working Well
- Interactive Prompts guide users through connection type, IP selection, RPC exposure and state-sync options.
- Modular Scripts (
1-install_avalanchego.sh
&2-install_beam_network.sh
) keep each concern isolated and maintainable. - Verbose Logging & Post-Install Guidance clearly surface NodeID extraction, service status checks, and log-tailing commands.
💡 Improvement Suggestions
- Root Check & Dependencies
At script start, bail early if notsudo
/root and verify required tools (wget
,jq
,tar
) are installed. - Non-Interactive Flags
Add--yes
/--quiet
options for headless or CI-driven installs. - Config Backup
Before mutatingnode.json
, createnode.json.bak
so users can roll back if needed. - Version Pinning & Dynamic Upgrades
Surface AvalancheGo & Subnet-EVM versions in variables (or fetch via GitHub API) to avoid stale downloads. - Shebang & Executability
Use#!/usr/bin/env bash
for portability and ensure both scripts arechmod +x
in the repo.
📝 Minor Nits
- Standardize quoting style around variables (e.g.
"$NODE_CONFIG"
). - Normalize log-grep patterns to avoid whitespace mismatches.
- Inline comments in
check-deploy.sh
could mention expected exit codes for CI clarity.
Overall, this is a solid ops-hygiene contribution. Once the above tweaks are in, I’m happy to ✅ approve and merge. Let’s empower validators everywhere! 🚀
No description provided.