Skip to content

Kig/powerline fixes #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Conversation

kigster
Copy link
Contributor

@kigster kigster commented Jun 30, 2025

Description

Merged the upstream and some fixes to Powerline Theme.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShellCheck found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@seefood seefood self-assigned this Jul 1, 2025
@seefood seefood marked this pull request as draft July 1, 2025 12:23
@seefood
Copy link
Contributor

seefood commented Jul 1, 2025

Hey kigster, thanks for the contribs.

Please note there are lots of checks failing. please install pre-commit and check commits before uploading.
I see you added a submodule and lots of files so this is no longer just a fix, this is adding a lot of new stuff, and that needs to be discussed. Are you on the way to create a bunch of new themes? can this be added without adding third party sources? Have you considered publishing an oh-my-posh config that will do it in a much simpler way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants