-
Notifications
You must be signed in to change notification settings - Fork 2k
[WIP]: Add the rewind FileBrowser to the Sync Modal #104511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
[WIP]: Add the rewind FileBrowser to the Sync Modal #104511
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~40 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~52151 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~661 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Hi @Automattic/lego, This PR is currently a work in progress, but I would like to have early feedback from you as I am breaking some principles as a pragmatic approach. The problem we are trying to solve is to have granular synchronization between Production and Staging sites, so the user can synchronize specific folders. This can be achieved using the Jetpack Rewind functionality, and that functionality uses the That The long-term solution could be to remove Redux and the external CSS from the What is your view about that? Do you think we can accept this |
👋 Hello hello, thanks for checking! Unfortunately, using the redux store is a strict NO in the new dashboard code, as it will pull can of worms to the bundle. For this case, the current workaround is to move the entire See a previous attempt for reference: https://github.com/Automattic/wp-calypso/pull/104267/files#diff-948eb1bc6a1f66eb77415f4d3530716c900aba197ea0672536d8f95fb28a80b8R112 Let us know if there's any more doubt! |
Related to DOTDEV-178
Proposed Changes
FileBrowser
component from Jetpack Backups to allow granular synchronizationWhy are these changes being made?
Testing Instructions
hosting/staging-sites-redesign
Push to Production
Pre-merge Checklist