Boost: Re-enable Module E2E tests #44141
Draft
+144
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new plugin `e2e-critical-css-force-errors` to simulate errors in Critical CSS Advanced Recommendations. - Updated e2e tests to activate the new plugin during the Critical CSS module tests. - Added the new plugin to the Docker configuration for proper testing environment setup.
… the 'Regenerate' button. This improves the test coverage for user interactions within the Critical CSS advanced recommendations.
…per activation/deactivation of the e2e-critical-css-force-errors plugin in tests. This enhances the reliability of the Critical CSS module tests.
…s and ensure visibility of critical CSS meta information. This streamlines the test flow and focuses on essential assertions.
- Updated test common.test.js structure to use `test.describe` and `test.beforeAll` for better organization and readability. - Enhanced the deactivation test to ensure proper cleanup of Critical CSS and dismissed recommendations.
…for testing toggling
github-actions
bot
added
[Plugin] Boost
…ncrese timeout got getSpeedScore
LiamSarsfield
added
the
I don't care about code coverage for this PR
Updated the method for checking module state from isModuleEnabled to waitForModuleState, which now waits for the toggle switch to become visible and checks for the expected class state. Adjusted related tests to utilize the new method for improved reliability and clarity.
Updat the toggleModule method to accept an expected state parameter, allowing for more precise control during module state changes. Adjusted related tests to reflect this change, ensuring they now verify the module state against the expected outcome.
Modified test cases to pass the expected state parameter when toggling modules in JetpackBoostPage. This change enhances clarity and ensures that the tests accurately reflect the intended module states. Removed an unused module from the test setup for better maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Merge this PR after #44140 is merged.
Addresses HOG-193: Enable Module E2E tests
Proposed changes:
This PR re-enables
projects/plugins/boost/tests/e2e/specs/modulestests e2e test suite that was temporarily disabled in commit 0eb34d93ca7522549dcec7ea35c09d4f39ef5406 due to flakiness:Re-enabled test suites:
specs/critical-css) - Boost: Re-enable Critical CSS and Concatenate E2E tests #44105specs/concatenate) - Boost: Re-enable Critical CSS and Concatenate E2E tests #44105specs/base) - Boost: Re-enable Base/Common E2E tests #44140specs/modules) - This PRTest suites still disabled (to be addressed in separate PRs):
specs/page-cache)specs/image-cdn)specs/image-guide)Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
No
Other information:
Testing instructions:
From the
projects/plugins/boost/tests/e2edirectory:Via ngrok (Recommended, but requires a subscription)
Replace
$tunnel_urlwith your actual ngrok URLInstall E2E test dependencies:
Start the Docker environment and tunnel:
Start your ngrok tunnel
ngrok http --url=$tunnel_url http://localhost:8889/Run the specific re-enabled test suites:
TUNNEL_URL=$tunnel_url pnpm run test:run specs/modulesVia localtunnel (Not recommended as it may be slow)
Install E2E test dependencies:
Start the Docker environment and tunnel:
pnpm run env:up && pnpm run tunnel:upRun the specific re-enabled test suites:
Expected behavior:
Verification steps:
Check that tests are running in CI:
Test stability: