Attempt to fix #80 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihadeed
reviewed
Jul 21, 2017
src/providers/image-loader.ts
Outdated
| } | ||
|
|
||
| private get isIonicWKWebView(): boolean { | ||
| return this.isWKWebView && location.host === 'localhost:8080'; | ||
| if (this.isWKWebView) { |
There was a problem hiding this comment.
I'd rather make this method do this:
return this.isWKWebView && (location.host === 'localhost:8080' || (<any>window).LiveReload);Then we can remove declare var LiveReload;
src/providers/image-loader.ts
Outdated
| @@ -67,11 +69,28 @@ export class ImageLoader { | |||
| } | |||
|
|
|||
| private get isWKWebView(): boolean { | |||
| return this.platform.is('ios') && (<any>window).webkit; | |||
| if (this.platform.is('ios') && (<any>window).webkit && (<any>window).webkit.messageHandlers) { | |||
There was a problem hiding this comment.
Out of curiosity, why do we need webkit.messageHandlers ?
There was a problem hiding this comment.
I don't know whether it is necessary or not. When I was inspecting the issue with Livereload, I saw people are using with webkit.messageHandlers.
https://stackoverflow.com/questions/28795476/detect-if-page-is-loaded-inside-wkwebview-in-javascript
Therefore, I made this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.