Remove the platform.ready for the Observable #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er behavior in bad network area
|
|
|
I see, but using the platform.ready is really bad here, the behavior when I am using my phone in the subway (where the cache is important) is crazy, and also for huge amounts of my users... Do we need the platform.ready event to use the platform.is function ? |
…er behavior in bad network area
|
No, |
|
Then this commit could be better, and working for both ? And just for myself, you are using the !platform.is(cordova) first because Ionic is mainly used on desktop ? |
|
Yeah this PR looks good now. I'll merge it soon when I'm ready to publish a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the platform.ready event for faster loading and really better behavior in bad network areas. (As explained, sometimes, the platform.ready event is never fired, but it is hard to find why)