Z-Wave JS: Certification requirements for Meter CC not fulfilled #17
Assignees
Labels
backend
This bug or request (primary) involves the Home Assistant backend/integration (and its dependencies)
bug
Something isn't working but should by design
new feature
New feature or request
zwave-certification
Required for Z-Wave certification
Comments
marcelveldt
added
integration: zwave_js
zwave-certification
|
We need to add additional button entities to implement this |
marcelveldt
added
new feature
|
is the And how does a device advertise support for reset? |
|
It's enough to pass the test (well, except for a bug in the test suite 🙄), but having buttons could be nice. Not sure. |
|
For certification there is nothing left to do, we have the service call. |
|
Can we close this and add a nice to have issue? We can link to this one I just want to make the scope clear as I triage the board |
marcelveldt
changed the title
|
done |
raman325
changed the title
|
sorry, this is what I meant ^ |
|
Tested again, looks like the service call isn't working as expected. I also found some discrepancies from the specs, which mean the reset calls will need an overhaul anyways: |
|
This mock-server script can be used to test the implementation. It simulates a node with 4 meter readings, two of which are accumulated and can be reset. Every 5 seconds, a random reading increases by a small amount. To test, ensure that a reset all only results in a single call to Z-Wave JS and a single // @ts-check
const { CommandClasses } = require("@zwave-js/core");
const { ccCaps, createMockZWaveRequestFrame } = require("@zwave-js/testing");
const { roundTo } = require("alcalzone-shared/math");
const { RateType, MeterCCReport } = require("zwave-js");
let simulationTimer;
process.on("SIGINT", () => {
if (simulationTimer) clearInterval(simulationTimer);
});
const values = new Map([
[0x00, 1],
[0x03, 2.5],
[0x04, 4],
[0x05, 50],
]);
/** @type {import("zwave-js/Testing").MockServerOptions["config"]} */
module.exports.default = {
nodes: [
{
id: 2,
capabilities: {
commandClasses: [
CommandClasses.Version,
ccCaps({
ccId: CommandClasses.Meter,
isSupported: true,
version: 6,
meterType: 0x01, // Electric
supportedScales: [0x00, 0x03, 0x04, 0x05],
supportedRateTypes: [RateType.Consumed],
supportsReset: true,
getValue: (scale) => {
return values.get(scale) ?? 0;
},
onReset: (options) => {
if (!options) {
values.set(0x00, 0);
values.set(0x03, 0);
} else {
const { scale, targetValue } = options;
values.set(scale, targetValue);
}
},
}),
],
},
behaviors: [
{
// Small hack - start the state simulation timer when the node
// receives a command from the controller
async onControllerFrame(controller, self, _frame) {
if (!simulationTimer) {
// Then send notifications regularly
simulationTimer = setInterval(() => {
// Randomly select a scale
const scale = Array.from(values.keys())[
Math.floor(Math.random() * values.size)
];
// Randomly increase the value by a small amount
const newValue = (values.get(scale) ?? 0)
+ roundTo(
Math.random() * 5,
1,
);
values.set(scale, newValue);
const cc = new MeterCCReport(self.host, {
nodeId: controller.host.ownNodeId,
type: 0x01, // Electric
scale,
rateType: RateType.Consumed,
value: newValue,
});
self.sendToController(
createMockZWaveRequestFrame(cc, {
ackRequested: false,
}),
);
// Tune this value according to how often you want to get notifications
}, 10000).unref();
}
return false;
},
},
],
},
],
}; |
This was referenced Jun 19, 2024
|
TODO
|
|
This issue is mostly fixed by home-assistant/core#119968, except the service call still behaves buggy: home-assistant/core#116222 IMO we should either remove the service call, or - if we want to support resetting individual meters - fix the behavior in the planned expert UI. I'll create new device diagnostics to reproduce. |
|
Shouldn't we fix the service call first? We can still deprecate it, in preference of the button entity, but before the service is removed, it should still work. |
|
Does having device diagnostics help for debugging a service call? If so, I'll make sure we have an up to date diagnostics file. |
|
Yes, it'll help. I'm looking at the service issue. I can't even get it to perform the driver call. I'll continue looking at this on Thursday if I don't solve it before then. |
|
Diagnostics: Screenshot: Driver logs: |
AlCalzone
added
zwave-certification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From core created by AlCalzone: home-assistant/core#92799
The problem
If a device reports support for resetting meters, the end user must be able to perform this action. The driver exposes a writeonly value in this case, see node diagnostics.
We should add additional button entities, similar to PING or the planned IDENTIFY (Indicator CC).
Diagnostics information
zwave_js-f0926e113c178046d0d249fcdc42964a-Node 58-24fb445b526b3d5d614f25141d6cc278.json.txt
The text was updated successfully, but these errors were encountered: