Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static EZSP version and multiple NCPs #1149

Open
mikomarrache opened this issue Sep 29, 2020 · 2 comments
Open

Static EZSP version and multiple NCPs #1149

mikomarrache opened this issue Sep 29, 2020 · 2 comments
Labels
bug EMBER pinned Will not be closed, even if stale

Comments

@mikomarrache
Copy link
Contributor

Hi,

The EZSP version used is stored as static variable:

/**
  * The current version of EZSP being used
  */
 protected static int ezspVersion = EZSP_MIN_VERSION;

When my application initializes multiple NCPs at the same moment, one of the response can't be read because the frame ID can't be found in the map. At some point, the application aborts the initialization and tries again, and the initialization is performed successfully.

Moreover, if multiple NCPs are used and support different EZSP versions, it probably won't work. (Though I didn't test it case to confirm)

Since I'm using NCPs that all support v8, the workaround I used is declare a static initializer block:

static {
        EzspFrame.setEzspVersion(8);
}

Thanks,
Mickael

@stale
Copy link

stale bot commented Nov 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 28, 2020
@cdjackson cdjackson removed the wontfix label Nov 28, 2020
@stale
Copy link

stale bot commented Jan 30, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug EMBER pinned Will not be closed, even if stale
Projects
None yet
Development

No branches or pull requests

2 participants