From 8ead66b46ffa9770545689371cc982d3164d9603 Mon Sep 17 00:00:00 2001 From: Raviraj Baraiya Date: Tue, 12 Jul 2022 11:33:45 +0530 Subject: [PATCH 1/3] testWriteArgumentObjectToJSONFile class modification --- client/src/test/java/zingg/client/TestArguments.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/test/java/zingg/client/TestArguments.java b/client/src/test/java/zingg/client/TestArguments.java index 936498609..820c9da01 100644 --- a/client/src/test/java/zingg/client/TestArguments.java +++ b/client/src/test/java/zingg/client/TestArguments.java @@ -272,7 +272,7 @@ public void testWriteArgumentObjectToJSONFile() { Pipe outputPipe = new Pipe(); outputPipe.setName("output"); outputPipe.setFormat(Format.CSV); - outputPipe.setProp("location", "examples/febrl/output.csv"); + outputPipe.setProp("location", "tmp/testArguments/output.csv"); args.setOutput(new Pipe[] {outputPipe}); args.setBlockSize(400L); From 2ba2693ef1ceca659aa4acf0becc714d038fe1a7 Mon Sep 17 00:00:00 2001 From: Raviraj Baraiya Date: Tue, 12 Jul 2022 17:21:28 +0530 Subject: [PATCH 2/3] Arguments.writeArgumentsToJSON changes --- client/src/test/java/zingg/client/TestArguments.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/src/test/java/zingg/client/TestArguments.java b/client/src/test/java/zingg/client/TestArguments.java index 820c9da01..c9aac7844 100644 --- a/client/src/test/java/zingg/client/TestArguments.java +++ b/client/src/test/java/zingg/client/TestArguments.java @@ -272,13 +272,13 @@ public void testWriteArgumentObjectToJSONFile() { Pipe outputPipe = new Pipe(); outputPipe.setName("output"); outputPipe.setFormat(Format.CSV); - outputPipe.setProp("location", "tmp/testArguments/output.csv"); + outputPipe.setProp("location", "examples/febrl/output.csv"); args.setOutput(new Pipe[] {outputPipe}); args.setBlockSize(400L); args.setCollectMetrics(true); args.setModelId("500"); - Arguments.writeArgumentsToJSON("configFromArgObject.json", args); + Arguments.writeArgumentsToJSON("tmp/testArguments/configFromArgObject.json", args); //reload the same config file to check if deserialization is successful Arguments newArgs = Arguments.createArgumentsFromJSON("configFromArgObject.json", "test"); From 2ff88dd5077f8b573aa290fe36bb440d6d394789 Mon Sep 17 00:00:00 2001 From: Raviraj Baraiya Date: Wed, 13 Jul 2022 12:30:05 +0530 Subject: [PATCH 3/3] changes in testarg --- client/src/test/java/zingg/client/TestArguments.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/src/test/java/zingg/client/TestArguments.java b/client/src/test/java/zingg/client/TestArguments.java index c9aac7844..efd8a64b8 100644 --- a/client/src/test/java/zingg/client/TestArguments.java +++ b/client/src/test/java/zingg/client/TestArguments.java @@ -278,10 +278,10 @@ public void testWriteArgumentObjectToJSONFile() { args.setBlockSize(400L); args.setCollectMetrics(true); args.setModelId("500"); - Arguments.writeArgumentsToJSON("tmp/testArguments/configFromArgObject.json", args); + Arguments.writeArgumentsToJSON("/tmp/configFromArgObject.json", args); //reload the same config file to check if deserialization is successful - Arguments newArgs = Arguments.createArgumentsFromJSON("configFromArgObject.json", "test"); + Arguments newArgs = Arguments.createArgumentsFromJSON("/tmp/configFromArgObject.json", "test"); assertEquals(newArgs.getModelId(), "500", "Model id is different"); assertEquals(newArgs.getBlockSize(), 400L, "Block size is different"); assertEquals(newArgs.getFieldDefinition().get(0).getFieldName(), "fname", "Field Definition[0]'s name is different");