Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conbee III support #232

Merged
merged 22 commits into from
Nov 16, 2023
Merged

Conbee III support #232

merged 22 commits into from
Nov 16, 2023

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Nov 10, 2023

Depends on zigpy/zigpy#1281 to filter out extraneous ZDO endpoint in 0x26450900.

I'm targeting all available firmware versions for this device for this PR. Endpoint 0 being present in the simple descriptor response for the first firmware version will require a bugfix in zigpy.

To test:

pip uninstall zigpy zigpy-deconz
pip install 'git+https://github.com/puddly/zigpy-deconz@puddly/conbee-iii'
pip install 'git+https://github.com/puddly/zigpy@puddly/ignore-ep-0-descriptor'

@xxLeoxx93
Copy link

I assume these 3 lines are required if I want to use the Conbee 3 already?
When I use docker I propably have to do this after each pull?

@puddly puddly marked this pull request as ready for review November 14, 2023 16:23
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7264e6a) 98.76% compared to head (e56caad) 98.51%.

Files Patch % Lines
zigpy_deconz/zigbee/application.py 94.23% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #232      +/-   ##
==========================================
- Coverage   98.76%   98.51%   -0.26%     
==========================================
  Files           7        7              
  Lines         894      877      -17     
==========================================
- Hits          883      864      -19     
- Misses         11       13       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly puddly merged commit ecaf376 into zigpy:dev Nov 16, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants