Linear battery voltage #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 1, 2019
dmulcahey
reviewed
Dec 1, 2019
dmulcahey
reviewed
Dec 1, 2019
dmulcahey
reviewed
Dec 1, 2019
dmulcahey
reviewed
Dec 1, 2019
dmulcahey
reviewed
Dec 1, 2019
dmulcahey
reviewed
Dec 1, 2019
dmulcahey
reviewed
Dec 1, 2019
dmulcahey
reviewed
Dec 1, 2019
dmulcahey
reviewed
Dec 1, 2019
dmulcahey
reviewed
Dec 1, 2019
dmulcahey
reviewed
Dec 1, 2019
dmulcahey
reviewed
Dec 1, 2019
roblandry
commented
Dec 1, 2019
Adminiuga
reviewed
Dec 1, 2019
|
@Adminiuga wanna give this a peek when you have a moment? LMK if you think the strategy is good and if so i'll merge it in. Thanks. |
Adminiuga
reviewed
Dec 20, 2019
zhaquirks/__init__.py
Outdated
| log_msg = ( | ||
| f"{self.endpoint.device.manufacturer} {self.endpoint.device.model}, " | ||
| f"Voltage [RAW]:{raw_value} [Max]:{self.MAX_VOLTS} " | ||
| f"[Min]:{self.MIN_VOLTS}, Battery Percent: {percent/2}" |
There was a problem hiding this comment.
we shouldn't use F-Strings for logging, ie no need to format something that might not see the light of the day at all.
There was a problem hiding this comment.
@roblandry wanna change this so it can be merged?
|
other than debug log formatting looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of linear battery voltages.
Fixes: #199
Potential fix: #176
Reported values: