Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the way the args were being parsed to prevent duplicate trigg… #206

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

martinlong1978
Copy link
Contributor

Changed the way the args were being parsed to prevent duplicate triggers.

Due to the way that the args are matched in HA, the current
implementation meant that the left and right button were each firing
triggers for both themself, and the other. So left would fire
automations triggered on left and right, and vice versa.

I've changed the "press" and "hold" command parsing to start with a
16 bit int, the same as release, this prevents the zeros being
generated for both, which was spooking the way that HA matches these.

…ers.

Due to the way that the args are matched in HA, the current
implementation meant that the left and right button were each firing
triggers for both themself, and the other. So left would fire
automations triggered on left and right, and vice versa.

I've changed the "press" and "hold" command parsing to start with a
16 bit int, the same as release, this prevents the zeros being
generated for both, which was spooking the way that HA matches these.
@dmulcahey dmulcahey closed this Dec 1, 2019
@dmulcahey dmulcahey reopened this Dec 1, 2019
@dmulcahey
Copy link
Collaborator

@martinlong1978 can you log into travisci.org with your GH acct? Your PR won't build and it is flagged like this:

image

@martinlong1978
Copy link
Contributor Author

martinlong1978 commented Dec 1, 2019 via email

@martinlong1978
Copy link
Contributor Author

The abuse flag has cleared, however, I'm not sure how to get this PR to build.

@dmulcahey dmulcahey closed this Dec 3, 2019
@dmulcahey dmulcahey reopened this Dec 3, 2019
@dmulcahey dmulcahey merged commit 501492e into zigpy:dev Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants