Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Revert centralite battery map, add new 3.1v map #204

Closed
wants to merge 1 commit into from

Conversation

roblandry
Copy link
Contributor

To open discussion...

Reverts centralite battery map to last know working map. Uses 2.8-1.5v battery logic for centralite/smartthings.

Incorporates logic from: Smartthings Zigbee Button for #176.

Reverts: 6cba0ff
Fixes: #199
Potential fix: #176

@Adminiuga
Copy link
Contributor

IMO we just should have a linear volts to % function and each manufacturer/model just need to define the min/Max volts.

@roblandry
Copy link
Contributor Author

roblandry commented Nov 30, 2019

@Adminiuga i started the logic found in st for battery logic. #205 But, i would imagine there was a reason ST used the map for some devices... possibly the way they report voltage? I am not stuck on using a map, i honestly just wanted something to get my battery values back as the previous commit made like the bottom 50% of my batteries None.
Both of these PRs are mostly about opening discussion and us getting to a solid fix. Both WIPs. :-)

@dmulcahey
Copy link
Collaborator

IMO we just should have a linear volts to % function and each manufacturer/model just need to define the min/Max volts.

I like this idea the more that I think about it.

@roblandry
Copy link
Contributor Author

If I can get some ideas how to pass values from the quirks to init I'll get it done.

@Adminiuga
Copy link
Contributor

Adminiuga commented Dec 1, 2019 via email

@roblandry
Copy link
Contributor Author

Closing in favor of #208

@roblandry roblandry closed this Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants