-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kwargs to LevelControl
cluster command implementations
#1796
Conversation
Pull Request Test Coverage Report for Build 3165476503
💛 - Coveralls |
Codecov ReportBase: 71.69% // Head: 71.55% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #1796 +/- ##
==========================================
- Coverage 71.69% 71.55% -0.15%
==========================================
Files 239 239
Lines 7406 7421 +15
==========================================
Hits 5310 5310
- Misses 2096 2111 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The home-assistant/core#79361 will NOT be covered by this PR. |
@dmulcahey, @puddly I looked at all the And I don't know how address the home-assistant/core#79361 but I believe that is also related to the ZHA PR. |
FYI regarding that KoF issue: |
@javicalle can you rebase this please? |
88f26ad
to
f586688
Compare
Done. |
Thanks David |
In home-assistant/core#77676 some commands parameters has been replaced to keyword argument syntax.
Methods affected by the change:
_level_channel.move_to_level_with_on_off
_level_channel.move_to_level
_color_channel.color_loop_set
_color_channel.move_to_color_temp
_color_channel.enhanced_move_to_hue_and_saturation
_color_channel.move_to_hue_and_saturation
_color_channel.move_to_color
_identify_channel.trigger_effect
That changes breaks some implementations here.
After a quick review, I have added the
**kwargs
parameter in thecommand
method related to theLevelControl
cluster and related (NoManufacturerCluster
).Other implementations from other clusters have remained unchanged.
May fix: #1783