Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _TZE200_lnbfnyxd TRV #1792

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Add _TZE200_lnbfnyxd TRV #1792

merged 1 commit into from
Sep 27, 2022

Conversation

javicalle
Copy link
Collaborator

@javicalle javicalle commented Sep 27, 2022

Adds the manufacturer_code for the ' Tesla Smart Thermostatic Valve TV100'
I've also sorted the list alphabetically.

Fixes: #1786

Adds the `manufacturer_code` for the ' Tesla Smart Thermostatic Valve TV100'
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3137983153

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.66%

Totals Coverage Status
Change from base Build 3135902794: 0.0%
Covered Lines: 5300
Relevant Lines: 7396

💛 - Coveralls

@codecov-commenter
Copy link

Codecov Report

Base: 71.66% // Head: 71.66% // No change to project coverage 👍

Coverage data is based on head (789dd78) compared to base (3568fff).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1792   +/-   ##
=======================================
  Coverage   71.66%   71.66%           
=======================================
  Files         239      239           
  Lines        7396     7396           
=======================================
  Hits         5300     5300           
  Misses       2096     2096           
Impacted Files Coverage Δ
zhaquirks/tuya/ts0601_trv.py 33.21% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MattWestb
Copy link
Contributor

ZONNSMART TRVs is needing being added in ZHA for getting the presets working here:
https://github.com/home-assistant/core/blob/9084beda328ee29d98357379414a6c8d39db0af0/homeassistant/components/zha/climate.py#L760-L767

Also we have missing adding some and can you also adding the missing "brands" from the quirk ?

@javicalle
Copy link
Collaborator Author

Thanks for pointing it out.

Would everything be correct now?

@dmulcahey dmulcahey merged commit b8d8480 into zigpy:dev Sep 27, 2022
@javicalle javicalle deleted the patch-3 branch November 1, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tesla Smart Thermostatic Valve TV100 [Device Support Request]
5 participants