Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Tuya _TZE200_7eue9vhc #1763

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Add support for Tuya _TZE200_7eue9vhc #1763

merged 1 commit into from
Sep 25, 2022

Conversation

codypet
Copy link
Contributor

@codypet codypet commented Sep 17, 2022

Line 373 Added _TZE200_7eue9vhc in response to issue #1761
Fixes: #1761

Line 373 Added _TZE200_7eue9vhc
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3072120187

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.609%

Totals Coverage Status
Change from base Build 3040106202: 0.0%
Covered Lines: 5269
Relevant Lines: 7358

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.60%. Comparing base (a072ca3) to head (9b02307).
Report is 538 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1763   +/-   ##
=======================================
  Coverage   71.60%   71.60%           
=======================================
  Files         239      239           
  Lines        7358     7358           
=======================================
  Hits         5269     5269           
  Misses       2089     2089           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javicalle
Copy link
Collaborator

Have you verified if the behavior in HA is correct?
Mainly that the behavior in the UI corresponds to the movement of the shutter both when you operate it from HA and from the physical switch.

And can you reference the issue in your first post like this:

Fixes: #1761

That way the issue will be closed once the PR is merged.

@codypet
Copy link
Contributor Author

codypet commented Sep 18, 2022

@javicalle Yep. Works like a charm. I have the zha_quirks folder in my instance that has this updated ts0601_cover file the way I uploaded it and it works brilliantly.

Copy link
Collaborator

@javicalle javicalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javicalle javicalle added the needs final review PR is ready for a final review from a maintainer label Sep 18, 2022
@dmulcahey dmulcahey merged commit 939a944 into zigpy:dev Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs final review PR is ready for a final review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] Zigbee Roller Shade _TZE200_7eue9vhc
5 participants