Remove Aqara MAEU01 plugs from group 0 #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2936364081
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## dev #1706 +/- ##
==========================================
- Coverage 71.74% 71.69% -0.06%
==========================================
Files 237 237
Lines 7195 7206 +11
==========================================
+ Hits 5162 5166 +4
- Misses 2033 2040 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
TheJulianJES
force-pushed
the
tjj/xiaomi_maeu01_remove_group_0
branch
from
7cd14d7
to
f24053e
Compare
dmulcahey
approved these changes
Aug 30, 2022
This was referenced Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on #1656, I noticed that all IKEA 4-button remotes control the device and that it doesn't seem possible to remove the MAEU01 plug from group 0 (in which it's in by default) using the HA UI.
Related:
(Note: The first commit is just a slight cleanup. Only the second commit includes the actual changes)
Also, it doesn't look like something similar is implemented anywhere else, so I'm not sure if the proposed changes are actually "good" but they do seem to work.
Note
This apparently doesn't fully solve the issue in all cases but already greatly reduces it. If you're seeing "random toggles" on your
MAEU01/SP-EUC01plug, see #1656 (comment) for more information.