Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NoManufacturerCluster classes #1572

Merged
merged 3 commits into from
May 23, 2022

Conversation

javicalle
Copy link
Collaborator

PR #1559 makes use of NoManufacturerCluster creating a new generic implementation outside of ts0601_dimmer file.
Once merged, a class refactor is needed to remove duplicate code.

@codecov-commenter
Copy link

Codecov Report

Merging #1572 (3ce6f12) into dev (c7f2c61) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1572      +/-   ##
==========================================
+ Coverage   80.31%   80.32%   +0.01%     
==========================================
  Files         227      227              
  Lines        6782     6776       -6     
==========================================
- Hits         5447     5443       -4     
+ Misses       1335     1333       -2     
Impacted Files Coverage Δ
zhaquirks/tuya/__init__.py 72.24% <ø> (ø)
zhaquirks/tuya/mcu/__init__.py 98.70% <ø> (ø)
zhaquirks/tuya/ts0601_dimmer.py 100.00% <100.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7f2c61...3ce6f12. Read the comment docs.

@coveralls
Copy link

coveralls commented May 19, 2022

Pull Request Test Coverage Report for Build 2354101816

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0005%) to 80.316%

Totals Coverage Status
Change from base Build 2351564478: 0.0005%
Covered Lines: 5439
Relevant Lines: 6772

💛 - Coveralls

@javicalle javicalle changed the title Refactor nm classes Refactor NoManufacturerCluster classes May 19, 2022
@javicalle javicalle added the needs final review PR is ready for a final review from a maintainer label May 19, 2022
@dmulcahey dmulcahey merged commit dab4d44 into zigpy:dev May 23, 2022
@javicalle javicalle deleted the refactor_nm_classes branch May 23, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs final review PR is ready for a final review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants