Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hue motion sensor refactor, new Hue outdoor sensor (SML004), removed invalid models #1506

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

TheJulianJES
Copy link
Collaborator

@TheJulianJES TheJulianJES commented Apr 17, 2022

  • This moves the quirk for the new Philips Hue motion sensor revisions (SML003, SML004) into the motion.py file where the quirk for the older Hue motion sensors already is.
  • This adds the new outdoor Hue sensor (SML004) to the new Hue motion sensor quirk.
  • This also removes the SML003 and SML004 model info (with "Philips" as the manufacturer) from the old quirk, as the signature of the old quirk doesn't apply to the new sensors at all:
    • The new sensors only use the ZHA profile instead of ZLL (new ones removed endpoint 1) and expose "Signify Netherlands B. V." as the manufacturer instead of "Philips"
    • Edit: The author of the original PR responded here and it seems like he's using the newer quirk and not the old quirk (which he made some changes though), since the signatures never matched.

Marking this as a draft until #1351 (comment) gets answered (in case there's actually a SML003/SML004 model with the old ZLL endpoint and the old manufacturer name – which I doubt). -> Edit: looks like there isn't, so PR should be ready for review

Basically, this PR is correct in somewhat reverting #1351, as no new motion sensors (SML003, SML004) exist with the old firmware/signature.

@codecov-commenter
Copy link

Codecov Report

Merging #1506 (4558dfb) into dev (16f298e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1506      +/-   ##
==========================================
- Coverage   80.36%   80.35%   -0.02%     
==========================================
  Files         227      226       -1     
  Lines        6704     6698       -6     
==========================================
- Hits         5388     5382       -6     
  Misses       1316     1316              
Impacted Files Coverage Δ
zhaquirks/philips/motion.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f298e...4558dfb. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2178861736

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 80.352%

Totals Coverage Status
Change from base Build 2176863750: -0.02%
Covered Lines: 5382
Relevant Lines: 6698

💛 - Coveralls

@TheJulianJES TheJulianJES marked this pull request as ready for review April 18, 2022 20:20
@dmulcahey dmulcahey merged commit fc76fcd into zigpy:dev Apr 19, 2022
@TheJulianJES TheJulianJES deleted the hue_motion_new branch April 19, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants