Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative quirk for IKEA E1812 button #1462

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

RenWal
Copy link
Contributor

@RenWal RenWal commented Apr 4, 2022

Some IKEA Tradfri shortcut buttons (E1812) expose the 0xFC7C manufacturer-specific input cluster but lack the WindowCovering cluster. This leads to the IkeaTradfriShortcutBtn quirk not being applied. This PR adds an alternative quirk that can be used with these buttons.

Closes #1204

RenWal added 2 commits April 4, 2022 16:03
Some of these buttons seem to expose the IKEA manufacturer-specific
cluster, but are lacking the WindowCovering cluster. This second
configuration caused the original quirk to not match.
@coveralls
Copy link

coveralls commented Apr 4, 2022

Pull Request Test Coverage Report for Build 2090414724

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 80.317%

Totals Coverage Status
Change from base Build 2071559900: 0.01%
Covered Lines: 5374
Relevant Lines: 6691

💛 - Coveralls

@dmulcahey dmulcahey merged commit b2c98db into zigpy:dev Apr 7, 2022
@RenWal RenWal deleted the shortcutbtn-quirks branch April 7, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] IKEA E1812 shortcut button does not use quirks
3 participants