Inovelli New Zigbee Dimmer #1435

InovelliUSA · 2022-03-16T23:13:04Z

Prepping files for the release of our new zigbee dimmer.

Creating Inovelli Quirk Files for an upcoming release

Creating the Inovelli VZM31-SN Quirk for an upcoming release

Creating Inovelli Quirk Files

Typo identified on Line 30, correcting as required.

Update VZM31-SN.py

Updates to address some validation errors.

Updated for isort

Updated w/ Black

Update VZM31-SN.py

Removing Line 103 due to flake8 error D211

More format fixes

dmulcahey · 2022-03-24T14:22:26Z

zhaquirks/inovelli/VZM31-SN.py

+    }
+
+    replacement = {
+        MODELS_INFO: [("Inovelli", "VZM31-SN")],


remove this from replacement

dmulcahey · 2022-03-24T14:24:04Z

zhaquirks/inovelli/VZM31-SN.py

+        ENDPOINTS: {
+            1: {
+                PROFILE_ID: zha.PROFILE_ID,
+                DEVICE_TYPE: DeviceType.DIMMABLE_LIGHT,


@Adminiuga should we map DeviceType.DIMMER_SWITCH to the light platform so that quirks don't have to change the device type like this?

PLEASE do. In development of this device I had to override in the very beginning to even get any dim levels. All dimmers need 0-100% brightness_pct attribute, etc, as provided by the light domain.

isn't DeviceType.DIMMER_SWITCH a "remote" device? Device really should report itself as "Dimmable_Light".
Check Section 7.5.5 of Zigbee HA Profile, document 05-3520-29. DIMMER_SWITCH is mandated to have client on/off, level control and identity clusters.

@kreene1987 what kind of dimmer is it? two gang or single gang?

isn't DeviceType.DIMMER_SWITCH a "remote" device? Device really should report itself as "Dimmable_Light".
Check Section 7.5.5 of Zigbee HA Profile, document 05-3520-29. DIMMER_SWITCH is mandated to have client on/off, level control and identity clusters.

Great point. I didn’t check this before hand.

If it is a single gang device, then the endpoint id 1 should be of a DIMMING_LIGHT device type, and the 2nd endpoint should be of a DIMMER_SWITCH device type. Similar to how GE46857 implemented it, none of the others got it right.

Similar to how GE46857 implemented it, none of the others got it right.

Can you link me to where this quirk is stored? I couldn't find GE or Jasco as a manuf in the quirks folder.

We'll get right on it for testing.

Why not change the firmware of the device so that it reports itself as the correct device types? You can do it with a quirk but if you can change the firmware to be more accurate it may help other platforms as well.

Yes, I meant that the correct fix is to update the device firmware. There's no quirk for GE 45857, but you can find signature in https://github.com/home-assistant/core/blob/bc194cd209d4261bf7e15aa89eac09be5685c3db/tests/components/zha/zha_devices_list.py#L1674

Why not change the firmware of the device so that it reports itself as the correct device types? You can do it with a quirk but if you can change the firmware to be more accurate it may help other platforms as well.

Thanks for the feedback all, we will discuss with the engineer.

dmulcahey · 2022-03-24T14:28:00Z

@InovelliUSA I believe you need to remove the - from the file name as well

InovelliUSA · 2022-03-24T21:34:49Z

Thanks, we will check it out.

Updating per recommended changes

Update parameter for firmware 9

Update for firmware v9

Update with second signature depending on firmware.

Swapping v9 class to topmost.

Updates per review recommendations

Format fix

Update VZM31SN.py

Update deprecated command

Update ordering of imports for isort

Update __init__.py

Syntax changes to resolve test failures

Update __init__.py

Removed unused imports and corrected / from naming

Update __init__.py

codecov-commenter · 2022-04-04T15:33:13Z

Codecov Report

Merging #1435 (8dd2da0) into dev (d60fa3d) will decrease coverage by 0.11%.
The diff coverage is 85.18%.

@@            Coverage Diff             @@
##              dev    #1435      +/-   ##
==========================================
- Coverage   80.47%   80.35%   -0.12%     
==========================================
  Files         225      229       +4     
  Lines        6505     6827     +322     
==========================================
+ Hits         5235     5486     +251     
- Misses       1270     1341      +71

Impacted Files	Coverage Δ
zhaquirks/inovelli/__init__.py	`75.00% <75.00%> (ø)`
zhaquirks/inovelli/VZM31SN.py	`100.00% <100.00%> (ø)`
zhaquirks/tuya/ts004f.py	`80.64% <0.00%> (-19.36%)`	⬇️
zhaquirks/tuya/ts0601_dimmer.py	`93.75% <0.00%> (-6.25%)`	⬇️
zhaquirks/tuya/ts0601_siren.py	`93.96% <0.00%> (-6.04%)`	⬇️
zhaquirks/__init__.py	`77.89% <0.00%> (-1.48%)`	⬇️
zhaquirks/tuya/mcu/__init__.py	`98.68% <0.00%> (-1.32%)`	⬇️
zhaquirks/xiaomi/aqara/plug_mmeu01.py	`78.12% <0.00%> (-0.83%)`	⬇️
zhaquirks/xiaomi/mija/smoke.py	`89.47% <0.00%> (-0.53%)`	⬇️
zhaquirks/xbee/__init__.py	`41.46% <0.00%> (-0.35%)`	⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d60fa3d...8dd2da0. Read the comment docs.

coveralls · 2022-04-04T15:35:06Z

Pull Request Test Coverage Report for Build 2258930270

46 of 54 (85.19%) changed or added relevant lines in 2 files are covered.
597 unchanged lines in 32 files lost coverage.
Overall coverage decreased (-0.1%) to 80.357%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
zhaquirks/inovelli/init.py	24	32	75.0%

Files with Coverage Reduction	New Missed Lines	%
zhaquirks/tuya/ts0211.py	1	84.21%
zhaquirks/tuya/mcu/init.py	2	98.04%
zhaquirks/tuya/ts0601_dimmer.py	2	93.75%
zhaquirks/xiaomi/aqara/ctrl_ln.py	2	88.89%
zhaquirks/xiaomi/mija/smoke.py	2	89.47%
zhaquirks/aurora/aurora_dimmer.py	3	82.61%
zhaquirks/ikea/init.py	3	70.0%
zhaquirks/tuya/ts0601_electric_heating.py	3	57.58%
zhaquirks/danfoss/thermostat.py	4	82.76%
zhaquirks/tuya/ts130f.py	4	83.02%

Totals
Change from base Build 1976830509:	-0.1%
Covered Lines:	5486
Relevant Lines:	6827

💛 - Coveralls

Additional Parameter added

Update __init__.py

puddly

Thanks for the PR!

We've recently restructured our ZCL command and attribute definitions to hold more information. Could you make some changes to ensure this PR can be merged?

zhaquirks/inovelli/__init__.py

Updated for v10 firmware changes

Syntax updates and v10 firmware changes

codyhackw · 2022-04-25T19:30:15Z

Thanks for the PR!

We've recently restructured our ZCL command and attribute definitions to hold more information. Could you make some changes to ensure this PR can be merged?

@puddly I believe the most recent update should have the requested changes covered if you're able to confirm?

Parameter size change with v10 firmware

Update parameter size w/ v10 firmware

codyhackw and others added 3 commits March 15, 2022 17:06

Creating Inovelli Quirk Files

d03c157

Creating Inovelli Quirk Files for an upcoming release

Creating Inovelli VZM31-SN Quirk

9bb1d47

Creating the Inovelli VZM31-SN Quirk for an upcoming release

Merge pull request #1 from codyhackw/patch-1

ac897f9

Creating Inovelli Quirk Files

InovelliUSA changed the title ~~New Zigbee Dimmer~~ Inovelli New Zigbee Dimmer Mar 16, 2022

codyhackw and others added 13 commits March 17, 2022 13:34

Update VZM31-SN.py

f32c071

Typo identified on Line 30, correcting as required.

Merge pull request #2 from codyhackw/patch-2

722d1f7

Update VZM31-SN.py

Update VZM31-SN.py

7ad3c3a

Updates to address some validation errors.

Update __init__.py

6bb4a8e

Updated for isort

Update VZM31-SN.py

b50b164

Updated for isort

Update VZM31-SN.py

2f0e0e6

Updated w/ Black

Update __init__.py

9b214b2

Updated w/ Black

Update __init__.py

967f6f8

Update __init__.py

2aa7bed

Merge pull request #4 from codyhackw/patch-4

bd0d4f0

Update VZM31-SN.py

Update __init__.py

c686e6c

Removing Line 103 due to flake8 error D211

Update VZM31-SN.py

35aa805

Merge pull request #5 from codyhackw/patch-5

ca88dc5

More format fixes

dmulcahey reviewed Mar 24, 2022

View reviewed changes

codyhackw and others added 9 commits March 24, 2022 18:22

Update and rename VZM31-SN.py to VZM31SN.py

6e36ff1

Updating per recommended changes

Update __init__.py

6d20f61

Update parameter for firmware 9

Update VZM31SN.py

7a4a225

Update for firmware v9

Update VZM31SN.py

1136b8b

Update with second signature depending on firmware.

Update VZM31SN.py

fc36715

Swapping v9 class to topmost.

Merge pull request #6 from codyhackw/patch-6

bd4c5a6

Updates per review recommendations

Update VZM31SN.py

2a82f0e

Format fix

Merge pull request #7 from codyhackw/patch-7

b147ab1

Update VZM31SN.py

Update __init__.py

e0a17cc

Update deprecated command

codyhackw and others added 12 commits April 1, 2022 18:05

Update __init__.py

de0f66e

Update ordering of imports for isort

Update __init__.py

8c34c4a

Merge pull request #8 from codyhackw/patch-9

2a636df

Update __init__.py

Update __init__.py

03f7da5

Update VZM31SN.py

35a7f43

Merge pull request #9 from codyhackw/patch-10

abc7ab3

Update __init__.py

Update __init__.py

6d93880

Syntax changes to resolve test failures

Merge pull request #10 from codyhackw/patch-11

497ca51

Update __init__.py

Update __init__.py

adcce40

Merge pull request #11 from codyhackw/patch-12

4dc60d2

Update __init__.py

Update __init__.py

a00ccd4

Removed unused imports and corrected / from naming

Merge pull request #12 from codyhackw/patch-13

3790a02

Update __init__.py

codyhackw and others added 2 commits April 14, 2022 09:55

Update __init__.py

5087716

Additional Parameter added

Merge pull request #13 from codyhackw/patch-14

25ac7db

Update __init__.py

puddly requested changes Apr 22, 2022

View reviewed changes

codyhackw and others added 3 commits April 25, 2022 09:04

Update VZM31SN.py

9218dba

Updated for v10 firmware changes

Update __init__.py

c32180e

Merge pull request #14 from codyhackw/patch-15

8dd2da0

Syntax updates and v10 firmware changes

codyhackw and others added 2 commits April 28, 2022 21:55

Update __init__.py

9cbfd91

Parameter size change with v10 firmware

Merge pull request #15 from codyhackw/patch-16

cc3b57e

Update parameter size w/ v10 firmware

puddly approved these changes May 23, 2022

View reviewed changes

dmulcahey merged commit fb5b38e into zigpy:dev May 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Inovelli New Zigbee Dimmer #1435

Inovelli New Zigbee Dimmer #1435

InovelliUSA commented Mar 16, 2022

dmulcahey Mar 24, 2022

dmulcahey Mar 24, 2022

kreene1987 Mar 24, 2022

Adminiuga Apr 6, 2022

Adminiuga Apr 6, 2022

dmulcahey Apr 6, 2022

Adminiuga Apr 6, 2022

kreene1987 Apr 6, 2022

dmulcahey Apr 6, 2022

Adminiuga Apr 6, 2022

InovelliUSA Apr 6, 2022

dmulcahey commented Mar 24, 2022

InovelliUSA commented Mar 24, 2022

codecov-commenter commented Apr 4, 2022 •

edited

Loading

coveralls commented Apr 4, 2022 •

edited

Loading

puddly left a comment

codyhackw commented Apr 25, 2022

Inovelli New Zigbee Dimmer #1435

Inovelli New Zigbee Dimmer #1435

Conversation

InovelliUSA commented Mar 16, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmulcahey commented Mar 24, 2022

InovelliUSA commented Mar 24, 2022

codecov-commenter commented Apr 4, 2022 • edited Loading

Codecov Report

coveralls commented Apr 4, 2022 • edited Loading

Pull Request Test Coverage Report for Build 2258930270

💛 - Coveralls

puddly left a comment

Choose a reason for hiding this comment

codyhackw commented Apr 25, 2022

codecov-commenter commented Apr 4, 2022 •

edited

Loading

coveralls commented Apr 4, 2022 •

edited

Loading