Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IKEA ROTATED from const.py #1431

Merged
merged 3 commits into from
Mar 13, 2022
Merged

IKEA ROTATED from const.py #1431

merged 3 commits into from
Mar 13, 2022

Conversation

MattWestb
Copy link
Contributor

@MattWestb MattWestb commented Mar 13, 2022

Use ROTATED from const.py and deleting it in IKEA INIT and change the import for symfonisk.py so its using it from const.py.

Edit: I was forgetting that the retro dimer was using it 2 :-((

Using ROTATED from const and deleting in in IKEA INIT
I was forgetting the retro dimmer !!!
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2022

Codecov Report

Merging #1431 (d047331) into dev (43d6922) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1431      +/-   ##
==========================================
- Coverage   80.47%   80.47%   -0.01%     
==========================================
  Files         225      225              
  Lines        6506     6505       -1     
==========================================
- Hits         5236     5235       -1     
  Misses       1270     1270              
Impacted Files Coverage Δ
zhaquirks/ikea/__init__.py 68.75% <ø> (-0.64%) ⬇️
zhaquirks/ikea/dimmer.py 100.00% <100.00%> (ø)
zhaquirks/ikea/symfonisk.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d6922...d047331. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 13, 2022

Pull Request Test Coverage Report for Build 1975725075

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 80.477%

Totals Coverage Status
Change from base Build 1973564564: -0.003%
Covered Lines: 5235
Relevant Lines: 6505

💛 - Coveralls

@MattWestb MattWestb closed this Mar 13, 2022
@MattWestb MattWestb deleted the patch-3 branch March 13, 2022 07:44
@MattWestb MattWestb restored the patch-3 branch March 13, 2022 07:47
@MattWestb
Copy link
Contributor Author

MattWestb commented Mar 13, 2022

Ops !!
Renaming the branch was deleting the PR !!

@MattWestb MattWestb reopened this Mar 13, 2022
@MattWestb MattWestb changed the title Move ROTATED to const.py IKEA ROTATED from const.py Mar 13, 2022
@dmulcahey dmulcahey merged commit d60fa3d into zigpy:dev Mar 13, 2022
@MattWestb MattWestb deleted the patch-3 branch March 13, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants