Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Adeo LXEK-5 & ZBEK-26 color controllers #1394

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

mathoudebine
Copy link
Contributor

@mathoudebine mathoudebine commented Feb 24, 2022

Add support (including device automations for all buttons) for Adeo HR-C99C-Z-C045 Zigbee remote for color lights control (fixes #889)

  • Models: HR-C99C-Z-C045 (white) / HR-C99C-Z-C045-B (black)
  • Zigbee IDs: LXEK-5 (white) / ZBEK-26 (black)
  • Zigbee Device Type: "Color Control (0x800)"
  • Brand: Lexman (Leroy Merlin - french home improvement store)
  • Manufacturer: Adeo

@codecov-commenter
Copy link

Codecov Report

Merging #1394 (a4ddaa4) into dev (f9e25f4) will decrease coverage by 0.53%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1394      +/-   ##
==========================================
- Coverage   81.06%   80.52%   -0.54%     
==========================================
  Files         218      223       +5     
  Lines        6093     6453     +360     
==========================================
+ Hits         4939     5196     +257     
- Misses       1154     1257     +103     
Impacted Files Coverage Δ
zhaquirks/adeo/lxek5.py 80.95% <80.95%> (ø)
zhaquirks/const.py 100.00% <100.00%> (ø)
zhaquirks/tuya/ts0601_trv.py 81.48% <0.00%> (-4.94%) ⬇️
zhaquirks/tuya/__init__.py 72.45% <0.00%> (-4.72%) ⬇️
zhaquirks/tuya/ts0042.py 100.00% <0.00%> (ø)
zhaquirks/tuya/ts0044.py 100.00% <0.00%> (ø)
zhaquirks/sinope/light.py 100.00% <0.00%> (ø)
zhaquirks/sinope/switch.py 100.00% <0.00%> (ø)
zhaquirks/sinope/thermostat.py 100.00% <0.00%> (ø)
zhaquirks/tuya/mcu/__init__.py 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e25f4...a4ddaa4. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 24, 2022

Pull Request Test Coverage Report for Build 1965945680

  • 35 of 42 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 80.545%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zhaquirks/adeo/color_controller.py 33 40 82.5%
Totals Coverage Status
Change from base Build 1947732782: 0.02%
Covered Lines: 5200
Relevant Lines: 6456

💛 - Coveralls

@mathoudebine mathoudebine force-pushed the adeo-lxek-5 branch 3 times, most recently from c27f363 to 38ad8c0 Compare February 24, 2022 09:23
@mathoudebine mathoudebine changed the title Add support for Adeo LXEK-5 color controller Add support for Adeo LXEK-5 & ZBEK-26 color controllers Mar 10, 2022
Use scene cluster to manage scene buttons 1-4 on manufacturer cluster
@mathoudebine
Copy link
Contributor Author

Added support for ZBEK-26 (new black model) which has identical Zigbee support as LXEK-5 (white model), successfully tested with my devices!
PR finalized on my side and ready for integration, please let me know if something is wrong or missing 🙂

@herveja
Copy link

herveja commented Mar 13, 2022

Hello Matthieu
I just discovered your PR. Thank you for the job I was trying to do the same but I don't have the skill for it :)
btw, I get you code and add it as a custom quirk. It works well. but... the two button on the right of the remote (Arrow up / Arrow down) are not doing anything. For some reason nothing happened. No event in event listener ; nothin in the log.

Any clue ?

Thanks again for you contrib,
Hervé

@mathoudebine
Copy link
Contributor Author

Hello @herveja
Which model do you have ? Is it the white remote or the grey one ?
Can you confirm that the quirk is loaded for the device ?
adeo

For the debug, here is the configuration i use to be sure to have all the Zigbee logs :

logs:
  homeassistant.components.zha: debug
  bellows.zigbee.application: debug
  bellows.ezsp: debug
  zigpy: debug
  zigpy_cc: debug
  zigpy_deconz.zigbee.application: debug
  zigpy_deconz.api: debug
  zigpy_xbee.zigbee.application: debug
  zigpy_xbee.api: debug
  zigpy_zigate: debug
  zigpy_znp: debug
  zhaquirks: debug

@herveja
Copy link

herveja commented Mar 14, 2022

hello @mathoudebine
Thank you for your answer
I have the grey one (Model: HR-C99C-Z-C045-B) and the quark is loaded.
I tried for a 4th time to join the device and this time all is good - every button trigger a command (except command "color_up" and "color_down" that seems to be not linked to any action).

image

here is the log when joining the device to HA https://pastebin.com/tcTydSb7

@mathoudebine
Copy link
Contributor Author

Good news!
I don't know why you had to pair the device multiple times though.

For the color_up/color_down commands, i cannot trigger them either with the white remote or the grey one.
I may have made an error in the device automation for these commands:

(SHORT_PRESS, COLOR_UP): {

I will try to fix it when i have some spare time, or feel free to do so if you want!

@chriscamicas
Copy link

hi @mathoudebine I've just bought the grey remote, after the 2nd pairing it works, except for the color_up/down commands.
What do you think is your mistake ? I may try to fix it on my own and submit a PR...
Thanks again for the initial support !

@mycanaletto
Copy link

Same here, everything around the round cenral button doesn't bring up any events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] Adeo LXEK-5 remote (Lexman Enki)
7 participants