-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new ts0042 model #1376
Adding new ts0042 model #1376
Conversation
Adding one new model with 4 endpoints as the ts0044 but is only using the 2 first. Putting back the device type and moving OnOff to out and deleting power config from all EP but keeping it on EP1 sp battery reporting is working better.
Codecov Report
@@ Coverage Diff @@
## dev #1376 +/- ##
==========================================
+ Coverage 81.06% 81.07% +0.01%
==========================================
Files 218 218
Lines 6093 6097 +4
==========================================
+ Hits 4939 4943 +4
Misses 1154 1154
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 1881354174
💛 - Coveralls |
@MattWestb , does that mean that the It sounds like it could be completely removed (which would be an improvement). |
zha-device-handlers/zhaquirks/tuya/__init__.py Lines 777 to 783 in f9e25f4
Also adding sending default response so the switch is not repeating the commands and doing delays / blocking the device then the command is out of ZCL.. I only doing the trick deleting the cluster 0x0006 from in and adding it as one out cluster on the same endpoint (that it shall have being) and we dont getting any no working switch in ZHA GUI but its still working and is tested on 3 devices we have trying (ts0044, ts0042 and ts004f). As you see its real tyua devices = you is getting what you is paying for. |
Sorry, you're right, I got confused when reviewing the changes you had made. |
Its tuya devices so many things is little more then strange. I think its one part of housekeeping fixing bad things like this (deleting not working functions that making problem for users). |
Using the unknown cluster from INIT that makes if we is finding some functions of it then the device is getting the function we is implanting in the future. |
Adding one new model with 4 endpoints as the ts0044 but is only using the 2 first (hard and software recycling on high level from tuya then using the same for all switches and only changing the device ID !!).
Putting back the device type and moving OnOff to out and deleting power config from all EP but keeping it on EP1 so battery reporting is working better.
Fixes: #1375
The old is untouched but need being updated in the same way.