Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new model of TS0121 Tuya plug #1300

Merged
merged 3 commits into from
Jan 23, 2022
Merged

Add new model of TS0121 Tuya plug #1300

merged 3 commits into from
Jan 23, 2022

Conversation

Adminiuga
Copy link
Contributor

Add a new model of TS0121 Tuya plug.
Fixes #1299
I don't have such a plug so this needs testing to confirm it is working correctly.

@coveralls
Copy link

coveralls commented Jan 22, 2022

Pull Request Test Coverage Report for Build 1733468101

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 80.523%

Totals Coverage Status
Change from base Build 1708660039: 0.01%
Covered Lines: 4647
Relevant Lines: 5771

💛 - Coveralls

@ali1234
Copy link

ali1234 commented Jan 22, 2022

This certainly causes the quirk to be applied to my devices. The custom clusters are now shown in the cluster manager. The cluster manager works now and I can get the value of current_divisor, and it is 1000 as expected when the quirk is activated.

Tomorrow I will verify that the readings really are correct using my 2kW fan heater.

zhaquirks/tuya/ts0121_plug.py Outdated Show resolved Hide resolved
@ali1234
Copy link

ali1234 commented Jan 22, 2022

After running heater for 6 minutes I have this:

image

These readings seem to be correct.

@codecov-commenter
Copy link

Codecov Report

Merging #1300 (66bb3b8) into dev (dcee551) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1300      +/-   ##
==========================================
+ Coverage   80.51%   80.52%   +0.01%     
==========================================
  Files         212      212              
  Lines        5768     5771       +3     
==========================================
+ Hits         4644     4647       +3     
  Misses       1124     1124              
Impacted Files Coverage Δ
zhaquirks/tuya/ts0121_plug.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcee551...66bb3b8. Read the comment docs.

@javicalle
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] TS0121 _TZ3000_8nkb7mof still gives incorrect readings
6 participants