Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding devices #1264

Merged
merged 10 commits into from
Jan 17, 2022
Merged

adding devices #1264

merged 10 commits into from
Jan 17, 2022

Conversation

gromgsxr
Copy link
Contributor

@gromgsxr gromgsxr commented Jan 7, 2022

just correcting the lidl bulb reporting colour when its only dimmable see issue #1249 and adding a tuya single channel led controller as dimmable and not colour capable

@coveralls
Copy link

coveralls commented Jan 7, 2022

Pull Request Test Coverage Report for Build 1669992740

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 80.34%

Totals Coverage Status
Change from base Build 1662941388: 0.07%
Covered Lines: 4589
Relevant Lines: 5712

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #1264 (1823922) into dev (b0bbbfb) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1264      +/-   ##
==========================================
+ Coverage   80.27%   80.33%   +0.06%     
==========================================
  Files         207      209       +2     
  Lines        5693     5712      +19     
==========================================
+ Hits         4570     4589      +19     
  Misses       1123     1123              
Impacted Files Coverage Δ
zhaquirks/lidl/TS0501A.py 100.00% <100.00%> (ø)
zhaquirks/tuya/TS0501BS.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0bbbfb...1823922. Read the comment docs.

@MattWestb
Copy link
Contributor

Use https://black.vercel.app/ for fixing the formation and most test errors is going away.
(put the code in the left window and you is getting the fixed in the right one and use copy and pace)

@dmulcahey dmulcahey merged commit ea81a3f into zigpy:dev Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants