-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the braking TS001X quirk #1210
Conversation
Reversing the braking zha.DeviceType.ON_OFF_PLUG_IN_UNIT to original zha.DeviceType.ON_OFF_LIGHT that was braking automations in HA. Also adding the TS0012 the 2 gang version.
Pull Request Test Coverage Report for Build 1554362863
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## dev #1210 +/- ##
==========================================
+ Coverage 80.40% 80.41% +0.01%
==========================================
Files 207 207
Lines 5665 5668 +3
==========================================
+ Hits 4555 4558 +3
Misses 1110 1110
Continue to review full report at Codecov.
|
The TS001X quirk was added for getting more functions in the device #1152 but changing the DeviceType was one braking thing for user that have making automations then the old entries was deleted and one new not linked to the automation. If its possible getting it in HA fast as possible so user is not getting problems. Sorry for making problems and thanks in advance !! |
After fixing the small typo in the model name, it is working correctly in my HA installation. |
Thanks for feedback and testing !!! The good thing is your system is not braking more automations as long you have the local quirk installed and updating to next HA release with or without this fix. |
Thanks David !! |
Reversing the braking
zha.DeviceType.ON_OFF_PLUG_IN_UNIT
to originalzha.DeviceType.ON_OFF_LIGHT
that was braking automations in HA.Also adding the TS0012 the 2 gang version (usr have trying the new quirk changes)
Fix #1209