Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the braking TS001X quirk #1210

Merged
merged 3 commits into from
Dec 9, 2021
Merged

Fixing the braking TS001X quirk #1210

merged 3 commits into from
Dec 9, 2021

Conversation

MattWestb
Copy link
Contributor

Reversing the braking zha.DeviceType.ON_OFF_PLUG_IN_UNIT to original zha.DeviceType.ON_OFF_LIGHT that was braking automations in HA.
Also adding the TS0012 the 2 gang version (usr have trying the new quirk changes)
Fix #1209

Reversing the braking zha.DeviceType.ON_OFF_PLUG_IN_UNIT to original zha.DeviceType.ON_OFF_LIGHT that was braking automations in HA.
Also adding the TS0012 the 2 gang version.
@coveralls
Copy link

coveralls commented Dec 8, 2021

Pull Request Test Coverage Report for Build 1554362863

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 80.416%

Totals Coverage Status
Change from base Build 1544626539: 0.01%
Covered Lines: 4558
Relevant Lines: 5668

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2021

Codecov Report

Merging #1210 (7eaf88d) into dev (a4c6cdb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1210      +/-   ##
==========================================
+ Coverage   80.40%   80.41%   +0.01%     
==========================================
  Files         207      207              
  Lines        5665     5668       +3     
==========================================
+ Hits         4555     4558       +3     
  Misses       1110     1110              
Impacted Files Coverage Δ
zhaquirks/tuya/ts000x.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c6cdb...7eaf88d. Read the comment docs.

@MattWestb
Copy link
Contributor Author

The TS001X quirk was added for getting more functions in the device #1152 but changing the DeviceType was one braking thing for user that have making automations then the old entries was deleted and one new not linked to the automation.

If its possible getting it in HA fast as possible so user is not getting problems.

Sorry for making problems and thanks in advance !!

@MattWestb MattWestb changed the title Fixing the TS001X braking Fixing the braking TS001X quirk Dec 8, 2021
zhaquirks/tuya/ts000x.py Outdated Show resolved Hide resolved
@unaiur
Copy link

unaiur commented Dec 8, 2021

After fixing the small typo in the model name, it is working correctly in my HA installation.

@MattWestb
Copy link
Contributor Author

Thanks for feedback and testing !!!

The good thing is your system is not braking more automations as long you have the local quirk installed and updating to next HA release with or without this fix.

@dmulcahey dmulcahey merged commit e6138e4 into zigpy:dev Dec 9, 2021
@MattWestb MattWestb deleted the patch-1 branch December 9, 2021 12:31
@MattWestb
Copy link
Contributor Author

Thanks David !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] incompatible changes for Tuya TS0001 inwall switch
5 participants