Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xbee: fix updating values for PWM and OnOff clusters #1096

Merged
merged 2 commits into from
Oct 24, 2021

Conversation

Shulyaka
Copy link
Contributor

remote_at returns None on successful value set, and an exception on error. The current code assumes return of SUCCESS on success and other values on error, which is not correct. Fixing that.

@Shulyaka Shulyaka changed the title Xbee pwm fix xbee: fix updating values for PWM and OnOff clusters Oct 24, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1096 (6c2ae78) into dev (e4b8eda) will increase coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1096      +/-   ##
==========================================
+ Coverage   80.68%   80.76%   +0.07%     
==========================================
  Files         197      197              
  Lines        5308     5303       -5     
==========================================
  Hits         4283     4283              
+ Misses       1025     1020       -5     
Impacted Files Coverage Δ
zhaquirks/xbee/__init__.py 44.05% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4b8eda...6c2ae78. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1376615272

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 80.766%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zhaquirks/xbee/init.py 0 6 0.0%
Totals Coverage Status
Change from base Build 1375751760: 0.08%
Covered Lines: 4283
Relevant Lines: 5303

💛 - Coveralls

@dmulcahey dmulcahey merged commit e49f1be into zigpy:dev Oct 24, 2021
@Shulyaka Shulyaka deleted the xbee_pwm_fix branch October 24, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants