You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the dependency on coordinator-specific remote_at_command() by emulating it for other coordinators.
While this should work in theory with other coordinators, I could only test the code with xbee coordinator for the lack of hardware, I simulated it by slightly modifying zigpy_xbee code for the test.
Great! If you have it already as a router, then you probably have switches for digital i/o. Just try to flip those switches and see if you get any exception. Flipping a switch generates an AT command that configures the pin. You can also double check the pin state with XCTU,
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on coordinator-specific
remote_at_command()
by emulating it for other coordinators.While this should work in theory with other coordinators, I could only test the code with xbee coordinator for the lack of hardware, I simulated it by slightly modifying zigpy_xbee code for the test.