Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Alecto SMART-HEAT10 TRV #1067

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Adding Alecto SMART-HEAT10 TRV #1067

merged 2 commits into from
Oct 15, 2021

Conversation

MattWestb
Copy link
Contributor

@MattWestb MattWestb commented Oct 13, 2021

Adding _TYST11_8daqwrsj daqwrsj and _TZE200_8daqwrsj TS0601.
Renaming valve.py to ts0601_trv.py so it matching the "ts0601" family devices (tuya MCU with DP cluster).

Edit: Reversing the renaming then its braking all possible test for ts0601 devices.

Adding _TYST11_8daqwrsj daqwrsj and _TZE200_8daqwrsj TS0601
Renaming valve.py to ts0601_trv.py so it matching the "ts0601" family devices (tuya MCU with DP cluster).
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1337075347

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.096%

Totals Coverage Status
Change from base Build 1328905159: 0.0%
Covered Lines: 4187
Relevant Lines: 5163

💛 - Coveralls

@codecov-commenter
Copy link

Codecov Report

Merging #1067 (3e4964f) into dev (9a5bcd4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1067   +/-   ##
=======================================
  Coverage   81.09%   81.09%           
=======================================
  Files         195      195           
  Lines        5163     5163           
=======================================
  Hits         4187     4187           
  Misses        976      976           
Impacted Files Coverage Δ
zhaquirks/tuya/valve.py 86.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a5bcd4...3e4964f. Read the comment docs.

@MattWestb
Copy link
Contributor Author

I like doing the renaming but its braking over 60 tests and i dont have the knowledge fixing all things then its not only file names that need being changed its also the class names that is being changed and its over my competence.
The valve is the first tuya devices that was added so its have all "core" tests for all ts0601 devices that i dont like braking.

@dmulcahey dmulcahey merged commit 870e1d7 into zigpy:dev Oct 15, 2021
@MattWestb MattWestb deleted the patch-1 branch October 15, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants