Add setpoint command to imitate manual control of the thermostat #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Danfoss manufacturer command "Setpoint Command" to change behaviour of valve to instantly react on setpoint changes.
Change based on the proposal from @Adminiuga
Removed unnecessary imports/constants.
Quick fix for intendation
Added debug output for the setpoint command.
Corrections from flake8
How black should like it
Codecov Report
@@ Coverage Diff @@
## dev #1046 +/- ##
==========================================
- Coverage 81.20% 81.14% -0.07%
==========================================
Files 195 195
Lines 5128 5138 +10
==========================================
+ Hits 4164 4169 +5
- Misses 964 969 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a manufacturer specific setpoint command which is issued if the setpoint changes (issued by Home Assistant / HA, regardless if changed by the user or automations or whatever) to imitate the reaction of the thermostat if a user manually controls the temperature by turning the wheel.
Without this change the internal PID of the thermostat does eract very slowly on temperature changes issued by HA.