Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Fix reflection for one line docblocks #7299

Closed
wants to merge 1 commit into from
Closed

Fix reflection for one line docblocks #7299

wants to merge 1 commit into from

Conversation

lstrojny
Copy link
Contributor

@lstrojny lstrojny commented Mar 5, 2015

This fixes an issue where the parsing of single line docblocks fail and results in a syntax error with Ocramius/ProxyManager.

/cc @Ocramius

@malukenho
Copy link
Member

@lstrojny build is failing

{
/** Short Method Description */
public function doSomething()
{}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put each curly braces on one line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, it makes more sense to omit this class from our php_cs rules.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, that path is already excluded from our php-cs-fixer ruleset.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This asset is actually supposed to have this particular structure to trigger a failure

@weierophinney
Copy link
Member

@malukenho Note: please do not comment about build failures; we have status integration already with Travis, and authors will get notifications of build failures. Currently, all builds against master fail due to an environment issue anyways, so we need to check the results manually anyways to see if new, unknown failures are present.

@malukenho
Copy link
Member

@weierophinney Okay, not problem!

@weierophinney weierophinney added this to the 2.4.0 milestone Mar 10, 2015
weierophinney added a commit that referenced this pull request Mar 10, 2015
Fix reflection for one line docblocks
weierophinney added a commit that referenced this pull request Mar 10, 2015
@weierophinney
Copy link
Member

Merged to develop for release with 2.4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants