Add input_filter_specs feature from zfcampus/zf-content-validation and associated tests #7247
Conversation
…d associated tests
| /** | ||
| * @license http://opensource.org/licenses/BSD-3-Clause BSD-3-Clause | ||
| * @copyright Copyright (c) 2014 Zend Technologies USA Inc. (http://www.zend.com) | ||
| */ |
There was a problem hiding this comment.
change with :
/**
* Zend Framework (http://framework.zend.com/)
*
* @link http://github.com/zendframework/zf2 for the canonical source repository
* @copyright Copyright (c) 2005-2015 Zend Technologies USA Inc. (http://www.zend.com)
* @license http://framework.zend.com/license/new-bsd New BSD License
*/
like other files.
|
I will fix the headers today. BTW, tests seems to be ok. |
|
Headers changed \cc @samsonasik |
| @@ -46,6 +46,7 @@ public function __construct(ConfigInterface $configuration = null) | |||
| parent::__construct($configuration); | |||
|
|
|||
| $this->addInitializer(array($this, 'populateFactory')); | |||
| $this->addAbstractFactory('Zend\InputFilter\InputFilterAbstractServiceFactory'); | |||
There was a problem hiding this comment.
Remove this; we'll document how to enable it, but not all users of the InputFilterPluginManager will necessarily want to use this abstract factory.
There was a problem hiding this comment.
Well, I'll remove it. I added the abstract factory because I thought it would make the feature adoption easier. If it is not activated by default, I bother it won't be used. But maybe I'm wrong.
|
Disable input_filter_specs feature by default. Update tests. \cc @weierophinney |
| /** | ||
| * @param ServiceLocatorInterface $services | ||
| * | ||
| * @return \Zend\ServiceManager\AbstractPluginManager |
There was a problem hiding this comment.
It's returning a FilterPluginManager. I can change this at merge.
…rom-zfcampus/zf-content-validation Add input_filter_specs feature from zfcampus/zf-content-validation and associated tests
|
Merged to develop for release with 2.4. @jbenoit2011 Can you please also document this at https://github.com/zendframework/zf2-documentation ? :) |
|
@jbenoit2011 You can lift a lot of the docs for this from the zf-content-validation module if necessary, and just translate it to ReST from markdown. |
|
@weierophinney Sorry for the bad docblocks. I didn't check them, they come directly from zf-content-validation. So I think the update should be reflected to zf-content-validation. |
…import-input_filter_specs-from-zfcampus/zf-content-validation Add input_filter_specs feature from zfcampus/zf-content-validation and associated tests
I recently ask @weierophinney when input_filter_specs feature from zfcampus/zf-content-validation would be migrated to zendframework/zf2, as written in zf-content-validation README.
So we discuss about it on Twitter, and he suggested me to do it by myself. And so I did it.
This PR covers only the input_filter_specs feature. When it will be accepted, I will update the ZF2 doc.