This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Typo in #6598 pull request. #7168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Urgh, this is obviously because I couldn't get to write a test case for that exception -.- Thanks for spotting it! |
|
You welcome =). By the way, this exception exists in PHP >=5.5.0. I don't know how PHP < 5.5.0 will behave in this situation. I will try to write test for this when I have time. |
|
@filipp-qoma <5.5.0 uses a manual throwing mechanism |
gianarb
pushed a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
…endframework#6598-fix-typo-in-intl-exception-rethrow-logic' Close zendframework/zendframework#7168
gianarb
pushed a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
…endframework#6598-fix-typo-in-intl-exception-rethrow-logic' into develop Close zendframework/zendframework#7168 Forward port zendframework/zendframework#7168
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing of IntlException instance name