Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

.php_cs - add few rules #7164

Merged
merged 3 commits into from
Feb 1, 2015
Merged

Conversation

keradus
Copy link
Contributor

@keradus keradus commented Jan 27, 2015

Add few rules to PHP CS Fixer configuration that are already followed.

@keradus keradus changed the title .php_cs - add duplicate_semicolon rule .php_cs - add few rules Jan 27, 2015
@@ -37,12 +38,14 @@ $config->fixers(
'function_call_space',
'function_declaration',
'indentation',
'join_function',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should bump the composer.json version of the fixer, to avoid regressions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I don't get what's on your mind.
In composer there is latest stable version of PHP CS Fixer.
And what regression?

@gianarb
Copy link
Contributor

gianarb commented Jan 28, 2015

@Ocramius with other CR team developers have you thinking a set of common roles for cs-fix? (thoughts after split :P )

@keradus
Copy link
Contributor Author

keradus commented Jan 29, 2015

@gianarb that would be great. But currently we do not know which rules are followed in actual codebase - they are followed in most cases, but to turn them on they usually need little fixing to made Travis happy about them.

@gianarb
Copy link
Contributor

gianarb commented Jan 29, 2015

Np for this PR.. It's a general question 👍
Sorry for this intrusion 😄

@Ocramius Ocramius added this to the 2.4.0 milestone Feb 1, 2015
@Ocramius Ocramius self-assigned this Feb 1, 2015
Ocramius added a commit that referenced this pull request Feb 1, 2015
@Ocramius Ocramius merged commit d3e0ab3 into zendframework:develop Feb 1, 2015
@Ocramius
Copy link
Member

Ocramius commented Feb 1, 2015

@keradus thanks, merged after some further thoughts about it

@keradus keradus deleted the duplicate_semicolon branch February 1, 2015 13:11
weierophinney pushed a commit to zendframework/zend-i18n-resources that referenced this pull request May 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants