This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fixing deprecated preg_replace usage in classmap_generator.php #7135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -228,7 +231,11 @@ | |||
| $maxWidth = max($maxWidth, strlen($match[1])); | |||
| } | |||
|
|
|||
| $content = preg_replace('(\n\s+([^=]+)=>)e', "'\n \\1' . str_repeat(' ', " . $maxWidth . " - strlen('\\1')) . '=>'", $content); | |||
| $content = preg_replace_callback('(\n\s+([^=]+)=>)', function ($matches) | |||
| { | |||
There was a problem hiding this comment.
psr-2 coding standard, the brace { should be in same line after function ($matches), so it should be :
$content = preg_replace_callback('(\n\s+([^=]+)=>)', function ($matches) {
|
Thanks @samsonasik! Fixed. |
Ocramius
added a commit
that referenced
this pull request
Jan 18, 2015
…ssmap-generator' Close #7135
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With php >= 5.5, the /e parameter in preg_replace is deprecated and gives the warning:
As suggested, this PR changes the preg_replace to preg_replace_callback.