try fix travis cs develop again

[samsonasik]

latest travis develop built seems .php_cs config ->notPath('Zend/Db/Sql/Select.php') didn't work, let's see now.

[samsonasik]

hm.., it seems .php_cs config didn't effect the cs, still error :

Running library/Zend/Db CS checks

Loaded config from ".php_cs"

..................F.............................................................................................................................................................................

Legend: ?-unknown, I-invalid file syntax, file ignored, .-no changes, F-fixed, E-error

1) Sql/Select.php (join_function)

[samsonasik]

@Ocramius any idea ?

[Ocramius]

@samsonasik run the same command with a --diff (see #7057) and you'll get a better output

[samsonasik]

it gets output with diff :

Running library/Zend/Db CS checks
Loaded config from ".php_cs"
...........................................................................................................................................................................F....................
Legend: ?-unknown, I-invalid file syntax, file ignored, .-no changes, F-fixed, E-error
   1) Sql/Select.php (join_function)
      ---------- begin diff ----------
      --- Original
      +++ New
      @@ @@
            */
      -    public function join($name, $on, $columns = self::SQL_STAR, $type = self::JOIN_INNER)
      +    public function implode($name, $on, $columns = self::SQL_STAR, $type = self::JOIN_INNER)

as the exclude with ->notPath didn't work

[Ocramius]

Meh, I'd rather remove that rule instead (buggy)

[samsonasik]

the join -> implode issue itself patched in dev-master of php-cs-fixer PHP-CS-Fixer/PHP-CS-Fixer@830e64a . should just pointed to dev-master#commit instead ?

[Ocramius]

@samsonasik I'd wait for a stable release instead

[Ocramius]

(and revert that fixer rule for now)

[samsonasik]

ok, rule reverted ;)

[Ocramius]

@samsonasik weirdly, still failing

[Ocramius]

Ah, sorry, you probably misunderstood what I was thinking of this rule

[samsonasik]

maybe "join_function" rule?

Warm regards,

Abdul Malik Ikhsan

Pada 30 Des 2014, pukul 01.58, Marco Pivetta notifications@github.com menulis:

Ah, sorry, you probably misunderstood what I was thinking of this rule

—
Reply to this email directly or view it on GitHub.

[Ocramius]

Meh, was linking the wrong hash :-) https://github.com/zendframework/zf2/blob/ce693869bac0cef153227250d9a22a4d568ff0ff/.php_cs#L41

[samsonasik]

@Ocramius ok, done ;). "join_function" reverted.

[samsonasik]

travis develop green now ;)

[Ocramius]

Awesome, thanks!