This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Retrieve the InjectTemplateListener from the service manager. #7046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrabat
added a commit
to akrabat/zf2-action-skeleton
that referenced
this pull request
Dec 16, 2014
|
As usual, I have to bother about tests :-) |
The factory name is the fully qualified name to minimise chance of a name clash.
|
@Ocramius Tests written now! |
| */ | ||
| public function createService(ServiceLocatorInterface $serviceLocator) | ||
| { | ||
| $config = $serviceLocator->get('Config'); |
There was a problem hiding this comment.
Should have a different name (from the resulting config) to avoid confusion
There was a problem hiding this comment.
What about directly checking for controller_map here instead of having an additional isset() later on?
Also, ensure that controller_map is an array as the parameter to setControllerMap() is type hinted.
…implements ArrayAccess.
|
Updated as per comments. |
|
|
||
| $config = $serviceLocator->get('Config'); | ||
| if (isset($config['view_manager']) | ||
| && (is_array($config['view_manager']) || $config['view_manager'] instanceof ArrayAccess) |
There was a problem hiding this comment.
You can actually avoid checking isset($config['view_manager']), as a single isset() check is enough and won't cause notices. See http://3v4l.org/KPKN9
|
Updated. |
|
Looking good: adding to my next merge spree. |
Ocramius
added a commit
that referenced
this pull request
Jan 1, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 1, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 1, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 1, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 1, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 1, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 1, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 1, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 1, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 1, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 1, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 1, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 1, 2015
…anager' into develop Close #7046
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use your own InjectTemplateListener.