This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
test digest response is validated #6983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -815,4 +808,9 @@ protected function _parseDigestAuth($header) | |||
|
|
|||
| return $data; | |||
| } | |||
|
|
|||
| private function isValidMd5Hash($value) | |||
agree, but it's indeed a piece of legacy that was dragged behind and that is very security-sensitive: refactoring piece by piece is preferable to avoid massive breakages. |
jaapio
changed the title
|
@jaapio fyi, the |
|
I added this issue number as group. |
Ocramius
added a commit
that referenced
this pull request
Dec 16, 2014
weierophinney
pushed a commit
to zendframework/zend-authentication
that referenced
this pull request
May 14, 2015
…ponse-must-be-validated' into develop Close zendframework/zendframework#6983
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://scrutinizer-ci.com/g/Ocramius/zf2/issues/master/files/library/Zend/Authentication/Adapter/Http.php?orderField=path&order=asc
I made some improvements to the existing code. A rewrite would be better...