This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Use hydrator variable only when hydrator variable is assigned #6949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dkemper so no logical changes? |
|
No logical changes. |
| $hydratorOrName | ||
| )); | ||
| } | ||
| if (!$hydrator instanceof Hydrator\HydratorInterface) { |
There was a problem hiding this comment.
This won't be reached when I call prepareAndInject(0, $fieldset)
There was a problem hiding this comment.
You are right, but in my case it throws a "Notice" undefined variable hydrator. So i will add a !isset($hydrator). Are you ok with it?
There was a problem hiding this comment.
I think I'll have to check it out locally and see existing tests. Should be fine as-is
|
I will push my test. |
|
I'll merge as-is, seems like there was a bugfix after all ;-) |
Ocramius
added a commit
that referenced
this pull request
Nov 30, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 30, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 30, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 30, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hydrator variable is not in use before $this->getHydratorFromName() is called. i just fixed the structure.