Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

create a new file if mode is append and the file does not exist #6934

Conversation

rohm1
Copy link

@rohm1 rohm1 commented Nov 26, 2014

Currently if the write mode is append and the output file does not exists, the script will crash. This PR fixes the issue and unifies the append and write modes, as there is some duplicated code.

@Ocramius Ocramius added this to the 2.4.0 milestone Nov 26, 2014
@Ocramius Ocramius self-assigned this Nov 26, 2014
@Ocramius
Copy link
Member

@rohm1 please don't merge master or any origin branch into your PRs: rebase instead. commit rohm1/zf2@9857682 should be removed.

@rohm1 rohm1 force-pushed the bugfix/templatemap-generator-append-to-non-existing-file branch from 9857682 to 9f70235 Compare November 27, 2014 10:32
@rohm1
Copy link
Author

rohm1 commented Nov 27, 2014

I did a git reset --hard HEAD~1 and then git push origin HEAD --force, commit is removed.

Ocramius added a commit that referenced this pull request Nov 27, 2014
…g-file-in-templatemap-generator' into develop

Close #6934
@Ocramius
Copy link
Member

@rohm1 merged into develop at 21aa6e2, thanks!

@Ocramius Ocramius closed this Nov 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants