This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Memcached returns FALSE on failure #6871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so it's not required to check for NULL, too. The note Memcached returns NULL was a miss information in changelog of memcached-2.0
|
@marc-mabe as usual, I have to ask for tests. |
|
@Ocramius the existing tests already handle this. As noted above it's an (performance) improvement and all tests passed. |
|
Got it, will merge in a few. |
Ocramius
added a commit
that referenced
this pull request
Nov 14, 2014
|
@marc-mabe thanks, merged |
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…-false-on-failure-perf-improvement' Close zendframework/zendframework#6871
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…-false-on-failure-perf-improvement' into develop Close zendframework/zendframework#6871 Forward port zendframework/zendframework#6871
boesing
pushed a commit
to laminas/laminas-cache-storage-adapter-apc
that referenced
this pull request
May 24, 2020
…-false-on-failure-perf-improvement' Close zendframework/zendframework#6871
boesing
pushed a commit
to laminas/laminas-cache-storage-adapter-apc
that referenced
this pull request
May 24, 2020
…-false-on-failure-perf-improvement' into develop Close zendframework/zendframework#6871 Forward port zendframework/zendframework#6871
boesing
pushed a commit
to laminas/laminas-cache-storage-adapter-memcached
that referenced
this pull request
Jul 4, 2020
…-false-on-failure-perf-improvement' Close zendframework/zendframework#6871
boesing
pushed a commit
to laminas/laminas-cache-storage-adapter-memcached
that referenced
this pull request
Jul 4, 2020
…-false-on-failure-perf-improvement' into develop Close zendframework/zendframework#6871 Forward port zendframework/zendframework#6871
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so it's not required to check for NULL, too.
The note Memcached returns NULL was a miss information in changelog of memcached-2.0
PS: It's not a bug - it's an improvement as the result will be same ;)