This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Removed impossible condition #6850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If $this->curl would be true-ish when entering this method it would enter inside the first conditional block and inside $this->close will be set to null. Then when checking the second condition, that I removed, it will always logically evaluate to false.
|
@mesmerizero merged into |
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…de-in-zend-curl-adapter' into develop Close zendframework/zendframework#6850
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
$this->curlwould be true-ish when entering this method it would enter inside the first conditional block and inside$this->close()will be set tonull. Then when checking the second condition, that I removed, it will always logically evaluate to false and the block will be never entered regardless of the input or context.