This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Di runtime definition optimisation - Cache result of processing and inline the check #6746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`array_flip` followed by `array_keys` is much quicker than `array_unique`. We don't retain he array indices by doing this, but we don't need them in this case so can take advantage of the optimisation. Making the supertypes array unique reduces the amount of classes that DI has to work through.
nickpeirson
changed the title
|
@nickpeirson thanks for rebasing it :-) |
|
No problem, not sure where the previous PR went astray :/ Rebasing the others now as well. |
weierophinney
added a commit
that referenced
this pull request
Feb 23, 2015
…tion Di runtime definition optimisation - Cache result of processing and inline the check Conflicts: library/Zend/Di/Definition/RuntimeDefinition.php
weierophinney
added a commit
that referenced
this pull request
Feb 23, 2015
|
Merged to develop for release with 2.4. |
weierophinney
added a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
…DI-RuntimeCompiler-Optimisation Di runtime definition optimisation - Cache result of processing and inline the check Conflicts: library/Zend/Di/Definition/RuntimeDefinition.php
weierophinney
added a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed a long time was spent in runtime definitions on some of our requests and that calls to
processClasscould run into tens of thousands in some cases. AshasProcessedClass()was only called from one place, I've inlined it to reduce the method call and cached the result of the check, which has made a significant difference to requests that have significant numbers of calls toprocessClass.